net/nanocoap: Expose configurations to Kconfig#13243
Merged
bergzand merged 6 commits intoRIOT-OS:masterfrom Apr 8, 2020
Merged
net/nanocoap: Expose configurations to Kconfig#13243bergzand merged 6 commits intoRIOT-OS:masterfrom
bergzand merged 6 commits intoRIOT-OS:masterfrom
Conversation
This was referenced Jan 31, 2020
7062691 to
830cf87
Compare
Contributor
Author
|
Rebased to resolve conflicts. |
830cf87 to
ab93da3
Compare
bergzand
reviewed
Apr 7, 2020
Member
|
Please squash! |
cb51d08 to
0137a06
Compare
Contributor
Author
|
@bergzand squashed! |
Contributor
Author
|
@bergzand CI looks good |
bergzand
approved these changes
Apr 8, 2020
Member
bergzand
left a comment
There was a problem hiding this comment.
Straightforward integration of settings into Kconfig, nothing to see here →go
Contributor
Author
|
@bergzand thanks for reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This moves configuration macros from nanocoap to the
CONFIG_namespace, and exposes them to Kconfig.MODULE_NANOCOAPnow is selecting a hidden symbol introduced in #13227 to indicate that CoAP support is present, and that the generic configurations should be shown. There is no issue on selecting an undefined symbol, so we can merge this directly. In case #13227 is merged first I'll remove the default value that was added there.Testing procedure
examples/gcoapandexamples/nanocoap_servershould be working as usual.Issues/PRs references
Part of #12888
Related to #13227