Kconfig: Expose gnrc/ipv6 configurations#13066
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom Jan 10, 2020
Merged
Kconfig: Expose gnrc/ipv6 configurations#13066leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
Conversation
leandrolanzieri
requested changes
Jan 10, 2020
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Works as expected. Just two details on the prompts. Please address them and squash directly.
ebc6d1a to
b2f0642
Compare
Member
Author
|
Thanks @leandrolanzieri, addressed your comment. |
leandrolanzieri
approved these changes
Jan 10, 2020
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
@PeterKietzmann thanks! ACK
71 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR moves the configuration macros of
gnrc_ipv6found here to theCONFIG_namespace, and exposes them to Kconfig.As agreed offline with @leandrolanzieri I did not include the thread stacksize and priority parameters because these should be defined by the platform, if not changed manually. We might need a better solution to this in future.
In the configuration header file, some defines relate to the FIB & RPL (see here). I think this should changed together with adding "GNRC IPv6 NIB compile configurations" as proposed in #12888.
Testing procedure
examples/gnrc_networkingshould still work as usual.make menuconfigin the test application.Issues/PRs references
Part of #12888