Skip to content

tests/sys_arduino: fix test synchronization issues#12962

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_sys_arduino_fix
Jan 15, 2020
Merged

tests/sys_arduino: fix test synchronization issues#12962
aabadie merged 1 commit intoRIOT-OS:masterfrom
fjmolinas:pr_sys_arduino_fix

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas commented Dec 16, 2019

Contribution description

The test currently doesn't wait for synchronization of the serial
terminal the second time it is setup with Serial.begin this results
in the tests command being sent before the terminal is ready which
causes the test to fail. To fix this add an expect_exact on "Hello
arduino". (NOTE: this is different form interactive_sync which
synchronizes the start of the test, but here we must wait for the
uart to be started again.)

On slow platforms there might still be data in the Transmit shift register
when the uart is re-initialized, which causes the first character of the
print to be rubish, print an empty space to workaround this. A delay
also works but would have to be adapted to the baudrate, and would
lengthen startup code, it would also introduce timer depedencies in
unwanted places.

Testing procedure

  • Launch the test and open a serial terminal on arduino-uno "Hello Arduino" will be cleanly printed.
BOARD=arduino-uno make -C tests/sys_arduino flash term

019-12-16 11:55:04,560 # main(): This is RIOT! (Version: 2020.01-devel-1407-g755232-pr_sys_arduino_fix)!j
2019-12-16 11:55:04,576 # Hello Arduino!
  • on master you see rubish:
2019-12-16 11:55:45,764 # main(): This is RIOT! (Version: 2020.01-devel-1406-g615fc-HEAD)!�����Arduino!
BOARD=arduino-uno make -C tests/sys_arduino flash test 
/home/francisco/workspace/RIOT-test/dist/tools/pyterm/pyterm -p "/dev/riot/tty-arduino-uno" -b "9600" --noprefix --no-repeat-command-on-empty-line
Connect to serial port /dev/riot/tty-arduino-uno
Welcome to pyterm!
Type '/exit' to exit.


He: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2020.01-devel-1410-g2b9c8-pr_sys_arduino_fix)!j
Hello Arduino!
wrang
UNK
echo quite long string echoing on arduino module test
ECHO: quite long string echoing on arduino module test
numb 4242
4242 4242 1092 10222
time
5503012 5544456 5586796 OK END
print
print(int, BIN): 1111101011000111
println(int, BIN): 1111101011000111
print(int, OCT): 175307
println(int, OCT): 175307
print(int, DEC): -1337
println(int, DEC): -1337
print(int, HEX): fac7
println(int, HEX): fac7
print(unsigned int, BIN): 101010
println(unsigned int, BIN): 101010
print(unsigned int, OCT): 52
println(unsigned int, OCT): 52
print(unsigned int, DEC): 42
println(unsigned int, DEC): 42
print(unsigned int, HEX): 2a
println(unsigned int, HEX): 2a
print(long, BIN): 10110110011010011111110100101110
println(long, BIN): 10110110011010011111110100101110
print(long, OCT): 26632376456
println(long, OCT): 26632376456
print(long, DEC): -1234567890
println(long, DEC): -1234567890
print(long, HEX): b669fd2e
println(long, HEX): b669fd2e
print(unsigned long, BIN): 1001001100101100000001011010010
println(unsigned long, BIN): 1001001100101100000001011010010
print(unsigned long, OCT): 11145401322
println(unsigned long, OCT): 11145401322
print(unsigned long, DEC): 1234567890
println(unsigned long, DEC): 1234567890
print(unsigned long, HEX): 499602d2
println(unsigned long, HEX): 499602d2

make: Leaving directory '/home/francisco/workspace/RIOT-test/tests/sys_arduino'

Issues/PRs references

@fjmolinas fjmolinas added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework labels Dec 16, 2019
@fjmolinas fjmolinas requested a review from aabadie December 16, 2019 11:03
@aabadie aabadie mentioned this pull request Dec 17, 2019
Merged
@fjmolinas
tests/sys_arduino: fix test synchronization issues
b581223 
The test currently doesn't wait for synchronization of the serial
terminal the second time it is setup with `Serial.begin`. This results
in the test commands being sent before the terminal is ready which
causes the test to fail. To fix this add an expect_exact on "Hello
arduino". (NOTE: this is different form `interactive_sync` which
synchronizes the start of the test, here we want `uart` to properly
re-init)
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Jan 15, 2020

With #12973 this only needs to match Hello arduino

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 15, 2020
aabadie
aabadie approved these changes Jan 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #12973 being merged, this one can go.

ACK

@aabadie aabadie merged commit fcde7a1 into RIOT-OS:master Jan 15, 2020
@fjmolinas fjmolinas deleted the pr_sys_arduino_fix branch January 15, 2020 12:42
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie approved these changes

Assignees

No one assigned

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2020.01

Development

Successfully merging this pull request may close these issues.

2 participants

@fjmolinas @aabadie