Kconfig: Expose gnrc/lorawan configurations#12923
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom Dec 20, 2019
Merged
Kconfig: Expose gnrc/lorawan configurations#12923leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
Conversation
71 tasks
Contributor
|
ping @jia200x! |
Member
|
I will give it a look |
fce8fd9 to
82c2722
Compare
jia200x
reviewed
Dec 20, 2019
jia200x
reviewed
Dec 20, 2019
Member
|
I added a small suggestion. Besides that, this looks good and works as expected (and the range of GNRC_LORAWAN_TIMER_DRIFT is fine) |
82c2722 to
b58b579
Compare
Member
|
ok, good! Thanks |
Member
|
let's wait for Murdock and then go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR changes the timer drift configuration for LoRaWAN to be expressed in per mille, instead of percentage. So now setting it to 1 means 0.1% drift correction. It also exposes GNRC LoRaWAN's configurations to Kconfig.
Testing procedure
gnrc_lorawanexample application should work as usual.make menuconfigin that application.Issues/PRs references
Part of #12888