CONTRIBUTING.md: migrate parts of wiki and add general tips#12786
Merged
miri64 merged 5 commits intoRIOT-OS:masterfrom Jan 16, 2020
Merged
CONTRIBUTING.md: migrate parts of wiki and add general tips#12786miri64 merged 5 commits intoRIOT-OS:masterfrom
miri64 merged 5 commits intoRIOT-OS:masterfrom
Conversation
Contributor
|
I looked over this and recommended what I could, maybe @kaspar030, @haukepetersen and @smlng could give some input. |
Contributor
|
and @OlegHahm |
miri64
commented
Nov 26, 2019
| the mailing list or open an issue saying which documentation is missing. The | ||
| other RIOTers will help you find the right format. | ||
|
|
||
| ### Issues |
Member
Author
There was a problem hiding this comment.
Please note that I think that this subsection ("Issues") and the subsection that follows ("Contribute code") somewhat duplicate what is already described in "Feature Requests", "Bug Reports", and "Pull Requests", just in a more concise form
Member
Author
|
Maybe also @aabadie? He wrote most of the original text in |
Member
Author
|
Ping? |
1 similar comment
Member
Author
|
Ping? |
MrKevinWeiss
approved these changes
Jan 9, 2020
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
I think it is an improvement, maybe this will get the ball rolling. 1 ACK.
Contributor
|
ACK! Please squash. |
fjmolinas
approved these changes
Jan 9, 2020
522eac6 to
7aae27d
Compare
Member
Author
Done |
Member
Author
|
Oops, this slipped through, I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This moves some of the contributing guidelines from various wiki pages to
CONTRIBUTING.mdin an effort to centralize documentation.It also adds a list of tips, that we discussed offline today.
Testing procedure
Read!
Issues/PRs references
Addresses #12779.