Skip to content

pkg/lora-serialization: bump to latest version and update test for AVR#12689

Merged
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/lora-serialization_update_8bit
Nov 11, 2019
Merged

pkg/lora-serialization: bump to latest version and update test for AVR#12689
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/lora-serialization_update_8bit

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Nov 11, 2019

Contribution description

This PR updates the lora-serialization package to the latest version which contains a fix to make it more compliant with non 32bit architectures.

This PR is also adapting the corresponding test for AVR platform: on AVR doubles are simply represented as float. Thus the values used for GPS in the test 02 are not encoded the same way on this platform.

There's also a small commit that changes a couple of cpp style comments into C-style comments.

Testing procedure

The following commands should work:

$ make -C tests/pkg-lora-serialization all test
$ make BOARD=samr21-xpro -C tests/pkg-lora-serialization flash test
$ make BOARD=atmega256rfr2-xpro -C tests/pkg-lora-serialization flash test

Issues/PRs references

Tick the lora-serialization item in #12651

@aabadie aabadie added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 11, 2019
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Nov 11, 2019
leandrolanzieri
leandrolanzieri approved these changes Nov 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Now this works on AVR, tests on other platforms still pass. ACK!

@leandrolanzieri leandrolanzieri merged commit 5febd49 into RIOT-OS:master Nov 11, 2019
@aabadie aabadie deleted the pr/pkg/lora-serialization_update_8bit branch November 11, 2019 17:08
@aabadie aabadie mentioned this pull request Nov 15, 2019
Closed
13 tasks
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

Assignees

No one assigned

Labels

Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2020.01

Development

Successfully merging this pull request may close these issues.

3 participants

@aabadie @leandrolanzieri @fjmolinas