tests/gnrc_rpl_srh: fix test assumption [backport 2019.10]#12443
Merged
kb2ma merged 3 commits intoRIOT-OS:2019.10-branchfrom Oct 14, 2019
Merged
tests/gnrc_rpl_srh: fix test assumption [backport 2019.10]#12443kb2ma merged 3 commits intoRIOT-OS:2019.10-branchfrom
kb2ma merged 3 commits intoRIOT-OS:2019.10-branchfrom
Conversation
If the destination address or an address within the source route is multicast within a RPL source routing header, a receiving node is supposed to just discard the packets, but not to send an ICMPv6 error message, as the test assumes at the moment. Source: https://tools.ietf.org/html/rfc6554#section-4.2 (cherry picked from commit ee2126a)
A node is not supposed to send an ICMPv6 error message when the destination or one of the addresses in the source route is multicast but is supposed to be silently discarded (see [RFC4443] and [RFC6554]). If we leave the `err_ptr` unset, the [node will not send an error message][err_ptr set]. [RFC 4443]: https://tools.ietf.org/html/rfc4443#section-2.4 [RFC 6554]: https://tools.ietf.org/html/rfc6554#section-4.2 [err_ptr set]: https://github.com/RIOT-OS/RIOT/blob/9bc600a/sys/net/gnrc/network_layer/ipv6/ext/rh/gnrc_ipv6_ext_rh.c#L100-L105 (cherry picked from commit a279228)
(cherry picked from commit 3e7f255)
kb2ma
approved these changes
Oct 14, 2019
Member
kb2ma
left a comment
There was a problem hiding this comment.
git range-diffshows commits identical, and the tests fail in the same way.
80 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12440
Contribution description
If the destination address or an address within the source route is multicast within a RPL source routing header, a receiving node is supposed to just discard the packets, but not to send an ICMPv6 error message, as the test assumes at the moment.
Source: https://tools.ietf.org/html/rfc6554#section-4.2
There is also a fix that prevents the implementation from sending such an error message: If we leave the
err_ptrunset in these cases, the node will not send an error message.Testing procedure
Read the algorithm provided above, especially the section regarding multicast:
The test cases that check multicast addresses in
tests/gnrc_rpl_srhshould now pass (the test in general does not pass completely (but will, when #12442 is cherry-picked).Issues/PRs references
Fixes one of the issues in #12436
Accompanies #12442