cpu/esp32: reimplementation of module esp_can as module periph can#11989
Merged
vincent-d merged 5 commits intoRIOT-OS:masterfrom Sep 23, 2019
Merged
cpu/esp32: reimplementation of module esp_can as module periph can#11989vincent-d merged 5 commits intoRIOT-OS:masterfrom
vincent-d merged 5 commits intoRIOT-OS:masterfrom
Conversation
Contributor
Author
|
@vincent-d Will it be possible for you to review this PR? |
Member
|
Looks good to me. I can't test it and it needs a rebase. I'll ACK once it's rebased. |
a711dde to
97dac49
Compare
CAN controller driver for ESP32 is no longer realized as separate module.
97dac49 to
d5bf41d
Compare
Contributor
Author
|
@vincent-d Thanks for reviewing. I have rebased the PR. I don't know someone else of RIOT maintainers who has the right hardware (Olimex ESP32 EVB for example) to test it. |
Contributor
Author
|
@yegorich Do you have the hardware? |
Contributor
|
@gschorcht I have Olimex ESP32 EVB and will try to test your PR next week. |
Contributor
|
I could test this PR using the above-mentioned commands on an Olimex ESP32 EVB board against a VScom USB-CAN Plus adapter. |
yegorich
approved these changes
Sep 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a refactoring of the ESP32 CAN controller driver implementation. Refactoring became necessary to follow the approach as introduced with PR #6178, which defines CAN interfaces as peripherals with automatic configuration.
Accordingly, the ESP32 CAN controller driver is no longer a separate module (
esp_can), but rather part of the peripheral drivers which is enabled when moduleperiph_canis used.Testing procedure
For testing, an ESP32 board with a connected CAN transceiver module is required. The only supported board is which already has such a CAN transceiver module on board, is the Olimex ESP32-EVB. Therefore, it is suggested to use this board.
After flashing the board with application
tests/conn_canthe
CAN-LandCAN-Hhave to be connected to a can bus. As counterpart a Linux box should be used with thecan-utils.After connecting to the ESP32 board in a terminal, the following tests can be executed.
candumpfirst):can dumpfirst and send within 10 seconds):Issues/PRs references
Implements #6178 for ESP32.