Skip to content

tests/log_printfnoformat: add test application & script#11968

Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/tests/printf_format
Aug 12, 2019
Merged

tests/log_printfnoformat: add test application & script#11968
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/tests/printf_format

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Aug 6, 2019

Contribution description

This PR add a test application for log_printfnoformat submodule. In the current state it fails to build on native and requires #11572 for the fix.

Testing procedure

Without the rebase it doesn't work.

Issues/PRs references

Adds a non regression tests for the fix provided in #11572

@aabadie aabadie added the Area: tests Area: tests and testing framework label Aug 6, 2019
@aabadie aabadie requested a review from fjmolinas August 6, 2019 07:49
@aabadie aabadie mentioned this pull request Aug 6, 2019
Merged
@aabadie aabadie force-pushed the pr/tests/printf_format branch from 91a808e to accff50 Compare August 6, 2019 10:06
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 6, 2019
@aabadie aabadie requested review from fjmolinas and removed request for fjmolinas August 6, 2019 14:05
fjmolinas
fjmolinas approved these changes Aug 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested on native and samr21-xpro, ACK.

@fjmolinas fjmolinas added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 9, 2019
@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Aug 12, 2019

There seems to have been an issue with tests/nordic_softdevice,

Downloading file [/tmp/dwq.0.6522966754663457/dbc5730a2c8c97cd06f8b50c832358f3/tests/nordic_softdevice/bin/nrf52dk/softdevice.hex]...
Failed to open file.

Script processing completed.

/tmp/dwq.0.6522966754663457/dbc5730a2c8c97cd06f8b50c832358f3/tests/nordic_softdevice/../../Makefile.include:550: recipe for target 'flash-only' failed
make: *** [flash-only] Error 1
make: Leaving directory '/tmp/dwq.0.6522966754663457/dbc5730a2c8c97cd06f8b50c832358f3/tests/nordic_softdevice'
make: Entering directory '/tmp/dwq.0.6522966754663457/dbc5730a2c8c97cd06f8b50c832358f3/tests/nordic_softdevice'
Timeout in expect script at "child.expect("All up, running the shell now")" (tests/nordic_softdevice/tests/01-run.py:8)

I don't think this has any relation with this PR, I would say it is a murdock problem (I've also seen it on other PR's), I'll re-trigger the build.

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Aug 12, 2019

@kaspar030 There seems to be an issue with tests/nordic_softdevice, it fails to download/open softdevice.hex any idea of what the issue might be?

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 12, 2019
@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Aug 12, 2019

GO!

@fjmolinas fjmolinas merged commit 7705f6a into RIOT-OS:master Aug 12, 2019
@aabadie aabadie deleted the pr/tests/printf_format branch August 21, 2019 15:31
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees

No one assigned

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR

Projects

None yet

Milestone

Release 2019.10

Development

Successfully merging this pull request may close these issues.

3 participants

@aabadie @fjmolinas @kb2ma