scapy_mqttsn: import MQTT-SN layer for scapy#11822
Closed
miri64 wants to merge 5 commits intoRIOT-OS:masterfrom
Closed
scapy_mqttsn: import MQTT-SN layer for scapy#11822miri64 wants to merge 5 commits intoRIOT-OS:masterfrom
miri64 wants to merge 5 commits intoRIOT-OS:masterfrom
Conversation
I provided a this also upstream [1] but it might take a while until there is a version of that one can install with `pip` etc. So for now I'd like to include this into our repo to provide some tests for our two MQTT-SN libraries, `emcute` and `asymcute`. [1]: secdev/scapy#2131
Member
Author
|
Applied changes according to review comment @ scapy (see secdev/scapy#2131) |
Member
Author
|
Updated this PR to reflect the final state of my PR to scapy. |
Member
Author
|
Version 2.4.3 of scapy includes which came out 2 days ago. I think we can close this :-) |
Member
Author
|
See RIOT-OS/riotdocker#77 for docker integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
I provided this also upstream but it might take a while until there is a version of that one can install with
pipetc (not to mention until the CI builders are sufficiently updated...). So for now I'd like to include this into our repo to provide some tests for our two MQTT-SN libraries,emcuteandasymcute.Testing procedure
Clone my contribution to scapy:
cd ../ git clone --branch mqttsn_layer https://github.com/miri64/scapyMake sure the python file to this repo is identical to the python file I contributed to scapy
(the output should be empty)
Run the tests I provided to scapy for python 3 with scapy test suite:
Issues/PRs references
None, but might help later on with #11811