tests/unittests: enable boards with enough memory#11602
Merged
jcarrano merged 2 commits intoRIOT-OS:masterfrom May 29, 2019
Merged
tests/unittests: enable boards with enough memory#11602jcarrano merged 2 commits intoRIOT-OS:masterfrom
jcarrano merged 2 commits intoRIOT-OS:masterfrom
Conversation
The board as renamed to openmote-cc2538.
Now that tests with packages have been moved out of `unittests`
re-enable boards with enough memory.
The removed boards list matches the boards that now compiled locally
with `BUILD_IN_DOCKER=1 make buildtest` and also the output of murdock
for boards that were able to link despite being in the list:
avsextrem:gnu
cc2538dk:gnu
firefly:gnu
mbed_lpc1768:gnu
msba2:gnu
openmote-b:gnu
openmote-cc2538:gnu
remote-pa:gnu
remote-reva:gnu
remote-revb:gnu
seeeduino_arch-pro:gnu
16 tasks
jcarrano
approved these changes
May 29, 2019
Contributor
jcarrano
left a comment
There was a problem hiding this comment.
Ok, if it compiles it compiles.
Contributor
Author
|
Thank you for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Now that tests with packages have been moved out of
unittestsre-enable boards with enough memory.
The removed boards list matches the boards that now compiled locally
with
BUILD_IN_DOCKER=1 make buildtestand also the output of murdockfor boards that were able to link despite being in the list:
The non-existing
openmoteboard is removed too.Testing procedure
The compilation detected in #11168 that it could link for these boards.
CI can correctly compile for all boards.
Compilation for these boards worked locally with
BUILD_IN_DOCKER=1 make buildtest.Issues/PRs references
Part of #10187