Skip to content

ipv6_ext: add fragmentation extension definitions#11593

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:ipv6_ext/feat/frag
Jun 4, 2019
Merged

ipv6_ext: add fragmentation extension definitions#11593
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:ipv6_ext/feat/frag

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented May 28, 2019 •
edited
Loading

Contribution description

This provides an initial import of IPv6 fragmentation header definitions and helper functions.

Testing procedure

export BOARD="<your favorite>"
make -C tests/unittests tests-ipv6_hdr flash-only test

Issues/PRs references

Addresses #5371 in part.

@miri64 miri64 added Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels May 28, 2019
@miri64 miri64 added this to the Release 2019.07 milestone May 28, 2019
@miri64 miri64 requested review from aabadie, cgundogan and cladmi May 28, 2019 11:23
@miri64 miri64 self-assigned this May 28, 2019
@miri64 miri64 force-pushed the ipv6_ext/feat/frag branch from 7d728da to 0d4b756 Compare May 28, 2019 11:24
@miri64 miri64 mentioned this pull request May 28, 2019
Closed
@miri64 miri64 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label May 28, 2019
@miri64 miri64 mentioned this pull request May 28, 2019
Merged
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented May 28, 2019

After adding flash to the test command, BOARD=${board} make --no-print-directory -C tests/unittests/ tests-ipv6_hdr flash test the arduino-zero iotlab-m3 samr21-xpro b-l475e-iot01a microbit works on IoT-LAB and on frdm-k64f frdm-kw41z msba2 mulle nrf52dk nucleo-f103rb pba-d-01-kw2x sltb001a stm32f3discovery on my local hardware.

On the arduino-mega2560 it failed with

ipv6_hdr_tests.test_ipv6_hdr_set_fl (tests/unittests/tests-ipv6_hdr/tests-ipv6_hdr.c 233) exp 173 was 173

but as @miri64 said, it was not introduced by these changes and it is indeed broken on master.

@cladmi cladmi added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label May 28, 2019
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jun 3, 2019

Fixed a warning by coccinelle.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jun 4, 2019

While implementing fragmentation, I realized that ipv6_ext_frag_set_offset_more() needed to be split up into two functions.

@miri64 miri64 removed the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Jun 4, 2019
@miri64 miri64 mentioned this pull request Jun 4, 2019
Merged
haukepetersen
haukepetersen approved these changes Jun 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, the header format is according to the standard and the helpers are useful and nicely documented. The unittests do also run fine (I tested on the microbit).

ACK

@miri64 miri64 force-pushed the ipv6_ext/feat/frag branch from 29bbc3c to 3e6cfcd Compare June 4, 2019 14:24
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jun 4, 2019

Squashed.

@miri64 miri64 merged commit 6b582fd into RIOT-OS:master Jun 4, 2019
@miri64 miri64 deleted the ipv6_ext/feat/frag branch June 4, 2019 15:12
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jun 4, 2019

Fixed a rebase error and a murdock issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haukepetersen haukepetersen haukepetersen approved these changes

@cladmi cladmi Awaiting requested review from cladmi

@cgundogan cgundogan Awaiting requested review from cgundogan

@aabadie aabadie Awaiting requested review from aabadie

Assignees

@miri64 miri64

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2019.07

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @cladmi @haukepetersen