cpu/cc2538: Add periph_uart_mode implementation#11503
Merged
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom May 29, 2019
Merged
cpu/cc2538: Add periph_uart_mode implementation#11503leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
Author
|
ping @yegorich |
yegorich
reviewed
May 9, 2019
| } uart_conf_t; | ||
| /** @} */ | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Without #ifndef DOXYGEN the UART API documentation is broken i.e. you have redundant defines.
What about excluding the redefines for now till there is a final solution for this issue.
dcd596b to
952cccd
Compare
smlng
reviewed
May 13, 2019
cpu/cc2538/periph/uart.c
Outdated
| { | ||
| assert(uart < UART_NUMOF); | ||
|
|
||
| assert( data_bits == UART_DATA_BITS_5 || |
Member
There was a problem hiding this comment.
remove space at the beginning and re-align accordingly - apply below too
This commit adds the periph_uart_mode USEMODULE It implements all functionality defined in the common uart driver This means all parity modes, data bits, and stop bits
952cccd to
0aa6b04
Compare
smlng
approved these changes
May 20, 2019
Member
smlng
left a comment
There was a problem hiding this comment.
untested ACK, otherwise this looks good
Member
leandrolanzieri
approved these changes
May 29, 2019
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
I tested this, works well. ACK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This pr adds the periph_uart_mode USEMODULE
It implements all functionality defined in the common uart driver
This means all parity modes, data bits, and stop bits
Testing procedure
Run
USEMODULE=periph_uart_mode BOARD=remote-revb make flash term -C tests/periph_uart/In the terminal run
init 1 115200and change all different modes (databits 5-8, parity n/e/o/m/s, and stop bits 1/2)
eg.
mode 1 5 o 2note: the API says that init must be called before mode however this implementation allows the user to also call mode at any time
Verify with a scope or analyser that the changes work/
Verify loopback works as well.
Issues/PRs references
Implementation based off RFC #10743
Taken over from #5899