cpu/stm32_common: remove WKUP2 pin enable#11167
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Mar 12, 2019
Merged
Conversation
aabadie
approved these changes
Mar 12, 2019
Contributor
aabadie
left a comment
There was a problem hiding this comment.
On my nucleo-l073rz board, I can confirm the mentioned problem is fixed by this PR.
ACK, let's merge when CI is green
Contributor
|
All green, let's go. Thanks @fjmolinas ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently StandBy mode is unusable for nucleo l0 boards. When looking at the datasheet:
But when looking at the boards schematic PC13 (wake-up pin 2), is also the user button which is connected to VDD, this means that unless user is holding the user button pressed all the time, a rising edge is triggered immediately. More so, it leaves the MCU in a weird state after reset.
Not enabling wake up pin 2 when entering StandBy fixes the issue.
Testing procedure
On nucleo boards that support LPM run:
make BOARD=nucleo-l073rz -C tests/periph_pm/ PORT=/dev/ttyACM0 clean flashunblock 0unblock 1unblock_rtc 1 3Issues/PRs references