examples: use coap_opt_finish() in gcoap based examples#10926
Merged
haukepetersen merged 3 commits intoRIOT-OS:masterfrom Mar 13, 2019
Merged
examples: use coap_opt_finish() in gcoap based examples#10926haukepetersen merged 3 commits intoRIOT-OS:masterfrom
haukepetersen merged 3 commits intoRIOT-OS:masterfrom
Conversation
6 tasks
kaspar030
approved these changes
Mar 12, 2019
Contributor
kaspar030
left a comment
There was a problem hiding this comment.
ACK.
tested gcoap, unittests, cord_ep (against aiocoap-rd). cord_epsim didn't show up in the endpoints of aiocoap-rd, but that might be aiocoap not speaking the protocol?
Contributor
|
@haukepetersen could you take a quick look at this? |
Contributor
|
@kb2ma this needs a rebase. |
f876ded to
34e8804
Compare
Member
Author
|
My pleasure, thanks for the review. |
Contributor
|
Successfully tested the ACK and go :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
#10892 updates gcoap documentation and internal message generation to use coap_opt_finish() rather than gcoap_finish(). This PR updates RIOT examples that use gcoap to also use coap_opt_finish(). The examples include the gcoap CLI example, cord_epsim, and cord_ep.
Testing procedure
FWIW, review my request_response, cord_ep, and cord_epsim automated tests for examples.
Issues/PRs references
Depends on #10892