make: test SERIAL for sam0 boards only if required#10840
Closed
smlng wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
make: test SERIAL for sam0 boards only if required#10840smlng wants to merge 1 commit intoRIOT-OS:masterfrom
smlng wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
If SERIAL is given as environment variable to the build/make system only test/check the SERIAL if needed for certain make goals, i.e., flash, flash-only, debug and debug-server. Otherwise ignore it and simply build. fixes RIOT-OS#10367
cladmi
suggested changes
Jan 23, 2019
Contributor
cladmi
left a comment
There was a problem hiding this comment.
This is not the way it should be handled. It is evaluated because PORT or FFLAGS is evaluated even when not needed and this should be removed.
When using deferred variables only, and not immediate variables, make will only evaluate the expressions when needed so when flash/debug/term will be used.
This means removing all immediate usages and export the value as it is not needed.
An effort has been started in this direction in #10440 as a split from #10342
19 tasks
Contributor
|
I added a tracking PR for removing useless exports and immediate evaluation. |
Member
Author
|
closing as per @cladmi commented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
If SERIAL is given as environment variable to the build/make system only
test/check the SERIAL if needed for certain make goals, i.e., flash,
flash-only, debug and debug-server. Otherwise ignore it and simply build.
Testing procedure
as described in #10367 run following command on master and with this PR
on master this will not build but fail, with this PR it builds as expected as SERIAL is not required and can be safely ignored.
Issues/PRs references
fixes #10367