at86rf2xx: Re-enable ack requests by default#10250
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Oct 25, 2018
Merged
Conversation
Properly splitting the flags between netdev_ieee802154 and the at86rf2xx driver had as side effect that the ACK REQ flag was no longer set by default. This commit reverts the default settings by enabling it again on startup. The current code calls the generic netdev setter to set the flag.
b63e954 to
c3da55b
Compare
miri64
approved these changes
Oct 25, 2018
Member
miri64
left a comment
There was a problem hiding this comment.
Tested on samr21-xpro and iotlab-m3 and confirmed that
a) the receiving node sends ACKs
b) fragmented ping6 yields better results than on master.
|
|
||
| static const netopt_enable_t enable = NETOPT_ENABLE; | ||
| netdev_ieee802154_set(&dev->netdev, NETOPT_ACK_REQ, | ||
| &enable, sizeof(enable)); |
Member
There was a problem hiding this comment.
Maybe add a comment on top what this does and why it is required (and if this can be reverted (?) in the future).
Member
Author
|
Thanks for the quick review! Do you still want me to add a comment in a new PR? :) |
Member
|
If you want an extra PR for that ^^" totally forgot my own remark when I hit the friendly green button. 😄 |
Member
|
(it was non-blocking anyway, so no big deal) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Properly splitting the flags between netdev_ieee802154 and the at86rf2xx
driver had as side effect that the ACK REQ flag was no longer set by
default. This commit reverts the default settings by enabling it again
on startup. The current code calls the generic netdev setter to set the
flag.
Testing procedure
Test if ack requests are set on ieee802.15.4 frames for the at86rf2xx driver. Setting up gnrc_networking and pinging a unicast (link local) address and sniffing the frames is probably the easiest way to test this.
Issues/PRs references
#9957