Skip to content

tests/littlefs: Move from unittests to regular test#10212

Merged
cladmi merged 1 commit intoRIOT-OS:masterfrom
bergzand:pr/pkg/littlefs_move
May 28, 2019
Merged

tests/littlefs: Move from unittests to regular test#10212
cladmi merged 1 commit intoRIOT-OS:masterfrom
bergzand:pr/pkg/littlefs_move

Conversation

@bergzand
Copy link
Copy Markdown
Member

@bergzand bergzand commented Oct 19, 2018

Contribution description

another one related to #10187

Testing procedure

Verify that tests/pkg_littlefs works: BOARD=<your-favourite> make -C tests/pkg_littlefs flash test

Issues/PRs references

#10187

@bergzand bergzand added Area: tests Area: tests and testing framework Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: fs Area: File systems CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Oct 19, 2018
@bergzand bergzand requested a review from vincent-d October 19, 2018 18:22
@bergzand bergzand mentioned this pull request Oct 19, 2018
Open
16 tasks
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 27, 2018

According to Murdock, some boards are to tiny for this tests and I believe the msp430 platforms need to be blacklisted (at least for z1 I can't compile).

miri64
miri64 reviewed Nov 27, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on samr21-xpro, nrf52dk and native

@miri64 miri64 added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Nov 27, 2018
@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 27, 2018

(you may squash immediately)

@miri64 miri64 removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Nov 27, 2018
@cladmi cladmi added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Nov 28, 2018
cladmi
cladmi reviewed Nov 28, 2018
View reviewed changes
tests/pkg_littlefs/tests/01-run.py Outdated
board = os.environ['BOARD']
# Increase timeout on "real" hardware
timeout = 120 if board is not 'native' else -1
child.expect('OK \(\d+ tests\)', timeout=timeout)
Copy link
Copy Markdown
Contributor

@cladmi cladmi Nov 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also directly inline changing this regex to a raw string.

Suggested change
child.expect('OK \(\d+ tests\)', timeout=timeout)
child.expect(r'OK \(\d+ tests\)', timeout=timeout)

cladmi
cladmi suggested changes Nov 28, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@cladmi cladmi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested with IoT-LAB with a rebased version on master with:

BOARDS="samr21-xpro pba-d-01-kw2x b-l475e-iot01a nrf52dk arduino-zero nrf52840dk iotlab-m3 microbit frdm-kw41z"
for board in ${BOARDS}; do BOARD=${board} RIOT_CI_BUILD=1 IOTLAB_NODE=auto-ssh BUILD_IN_DOCKER=1 DOCKER="sudo docker" make --no-print-directory -C tests/pkg_littlefs clean all flash test || break; done

wsn430-v1_3b does not compile with the following error: wsn430-v1_3b/littlefs/lfs_util.h:119: undefined reference to '__popcounthi2' so must be blacklisted

Same as the other filesystem test, make test took around 6-7 seconds only, with the time after reset included, so the 120 looks like not needed. The default 10s could be enough.

@bergzand bergzand force-pushed the pr/pkg/littlefs_move branch from 990a2b2 to f3b7b59 Compare May 28, 2019 13:56
@bergzand
Copy link
Copy Markdown
Member Author

bergzand commented May 28, 2019

Rebased!

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented May 28, 2019

I could run the test on arduino-mega2560 frdm-k64f frdm-kw41z msba2 nrf52dk nucleo-f103rb pba-d-01-kw2x sltb001a stm32f3discovery but currently failed on the mulle.

However mulle was not passing unittests in master either.

https://ci-ilab.imp.fu-berlin.de/job/experimental-pull-request-tests/21/consoleText

I am running the test on the IoT-LAB nodes too.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented May 28, 2019

I could successfully run the test on arduino-zero iotlab-m3 samr21-xpro b-l475e-iot01a microbit on IoT-LAB.

Please squash before murdock start running it :)

@bergzand bergzand force-pushed the pr/pkg/littlefs_move branch from fb515b5 to ce2a300 Compare May 28, 2019 14:40
@bergzand
Copy link
Copy Markdown
Member Author

bergzand commented May 28, 2019

Please squash before murdock start running it :)

squashed!

cladmi
cladmi approved these changes May 28, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@cladmi cladmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK tested on arduino-zero iotlab-m3 samr21-xpro b-l475e-iot01a microbit on IoT-LAB and on arduino-mega2560 frdm-k64f frdm-kw41z msba2 nrf52dk nucleo-f103rb pba-d-01-kw2x sltb001a stm32f3discovery locally.

It failed on mulle but the board failed to run unittests before, and it is not a stack size related issue, so unrelated to this PR.

cladmi
cladmi reviewed May 28, 2019
View reviewed changes
tests/pkg_littlefs/tests/01-run.py Outdated
# General Public License v2.1. See the file LICENSE in the top level
# directory for more details.

import os
Copy link
Copy Markdown
Contributor

@cladmi cladmi May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flake8 reports that this one is unused, you can squash it directly.
https://travis-ci.org/RIOT-OS/RIOT/builds/538272513#L441

Copy link
Copy Markdown
Member Author

@bergzand bergzand May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, should have noticed the warning locally. Fixed now

@bergzand bergzand force-pushed the pr/pkg/littlefs_move branch from ce2a300 to 748c81c Compare May 28, 2019 14:49
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented May 28, 2019

Now we just wait for CI :)

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented May 28, 2019

Same here, no problem for inline squashing the BOARD_INSUFFICIENT_MEMORY

@bergzand bergzand force-pushed the pr/pkg/littlefs_move branch from 748c81c to 1d38863 Compare May 28, 2019 15:39
@cladmi cladmi merged commit 7db8984 into RIOT-OS:master May 28, 2019
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented May 28, 2019

All green GO !

@bergzand
Copy link
Copy Markdown
Member Author

bergzand commented May 28, 2019

Thanks!

@bergzand bergzand deleted the pr/pkg/littlefs_move branch May 28, 2019 16:05
@MrKevinWeiss MrKevinWeiss added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 left review comments

@vincent-d vincent-d Awaiting requested review from vincent-d

+1 more reviewer

@cladmi cladmi cladmi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: fs Area: File systems Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bergzand @miri64 @cladmi @MrKevinWeiss