Skip to content

tests/hacl: Move from unittests to regular test#10209

Merged
cladmi merged 1 commit intoRIOT-OS:masterfrom
bergzand:pr/pkg/hacl_move
Oct 23, 2018
Merged

tests/hacl: Move from unittests to regular test#10209
cladmi merged 1 commit intoRIOT-OS:masterfrom
bergzand:pr/pkg/hacl_move

Conversation

@bergzand
Copy link
Copy Markdown
Member

@bergzand bergzand commented Oct 19, 2018

Contribution description

another one related to #10187

Testing procedure

Verify that tests/pkg_hacl works: BOARD=<your-favourite> make -C tests/pkg_hacl flash test

Issues/PRs references

#10187

@bergzand bergzand added Area: tests Area: tests and testing framework Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Oct 19, 2018
@bergzand bergzand mentioned this pull request Oct 19, 2018
Open
16 tasks
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 19, 2018
smlng
smlng approved these changes Oct 19, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(yet) untested ACK

@smlng smlng added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Oct 19, 2018
cladmi
cladmi suggested changes Oct 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@cladmi cladmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test does not work on iotlab-m3 and samr21-xpro.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 21, 2018

@smlng please do not ACK until you did everything. Putting the reviewed is enough.
It could lead someone to merge because it was already ACK.

cladmi
cladmi reviewed Oct 21, 2018
View reviewed changes
tests/pkg_hacl/Makefile Outdated
jiminy-mega256rfr2 mega-xplained waspmote-pro \
chronos msb-430 msb-430h telosb wsn430-v1_3b wsn430-v1_4 z1

TEST_ON_CI_WHITELIST += native
Copy link
Copy Markdown
Contributor

@cladmi cladmi Oct 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The make test command takes 9 seconds (including make term and reset) on samr21-xpro so could be activated on ci.
It can also be noticed as there is no timeout configured in the python test.

Copy link
Copy Markdown
Member Author

@bergzand bergzand Oct 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks for testing

Copy link
Copy Markdown
Member Author

@bergzand bergzand Oct 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to all

@bergzand
Copy link
Copy Markdown
Member Author

bergzand commented Oct 23, 2018

Added the nucleo-f032k6 and the nucleo-f042k6 to BOARD_INSUFFICIENT_MEMORY

@cladmi cladmi added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 3-testing The PR was tested according to the maintainer guidelines and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 23, 2018
cladmi
cladmi approved these changes Oct 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@cladmi cladmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes, and tested iotlab-m3 and samr21-xpro please squash.

For info: stack usage report:

  • samr21-xpro: 5120 ( 2580)
  • iotlab-m3: 5120 ( 2580)

@bergzand
Copy link
Copy Markdown
Member Author

bergzand commented Oct 23, 2018

Squashed!

@cladmi cladmi merged commit f160a75 into RIOT-OS:master Oct 23, 2018
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Oct 23, 2018

Hmm I forgot to add "run tests" on murdock… I will put it on your other PRs before merging and before I forget. It works on my computer at least.

@bergzand
Copy link
Copy Markdown
Member Author

bergzand commented Oct 23, 2018

Ah, that explains. :)

@bergzand bergzand deleted the pr/pkg/hacl_move branch October 23, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cladmi cladmi cladmi approved these changes

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bergzand @cladmi @smlng