pkg/semtech-loramac: Reduce timeout in timer#10180
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Oct 18, 2018
Merged
Conversation
aabadie
reviewed
Oct 17, 2018
| obj->timeout = (value - 22) * US_PER_MS; | ||
| triggered 50ms in advance to make sure the radio switches to RX mode on | ||
| time and doesn't miss any downlink messages, taking in consideration | ||
| possible xtimer innaccuracies. */ |
c7c7500 to
0aa12b9
Compare
Contributor
Author
|
Done! |
Contributor
|
According to the LoRa specs https://lora-alliance.org/resource-hub/lorawantm-specification-v11 Paragraph 3.3.1 the Receive Windows after Transmitting should account for a 20 microseconds (us or µs) delay inaccuracy the comment in current master:pkg/semtech-loramac/contrib/semtech_loramac_timer.c contains a comment starting at line 63 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This modifies the time in which the timeout is triggered in advance in the semtech-loramac timer module.
This value has been reduced for the latest version update of semtech_loramac package (#8864), but for datarates above 2 the downlink messages in the join process are missed (see #10103).
Testing procedure
1- Run the
lorawanexample with the current master. As it uses DR 5 it should fail to join.2- Apply the patch and the join should succeed.
Issues/PRs references
Fixes #10103
#8864