sys/net/gnrc_pktbuf_static: make hexdump optional

benpicco · benpicco · commit 982af61c82bd · 2024-11-11T15:17:40.000+01:00
diff --git a/sys/net/gnrc/pktbuf_static/gnrc_pktbuf_static.c b/sys/net/gnrc/pktbuf_static/gnrc_pktbuf_static.c
@@ -240,12 +240,13 @@ gnrc_pktsnip_t *gnrc_pktbuf_start_write(gnrc_pktsnip_t *pkt)
 }
 
 #ifdef DEVELHELP
-#ifdef MODULE_OD
 static inline void _print_chunk(void *chunk, size_t size, int num)
 {
     printf("=========== chunk %3i (%-10p size: %4" PRIuSIZE ") ===========\n", num, chunk,
            size);
+#ifdef MODULE_OD
     od_hex_dump(chunk, size, OD_WIDTH_DEFAULT);
+#endif
 }
 
 static inline void _print_ptr(_unused_t *ptr)
@@ -266,11 +267,9 @@ static inline void _print_unused(_unused_t *ptr)
     _print_ptr(ptr->next);
     printf(", size: %4u) ~\n", ptr->size);
 }
-#endif
 
 void gnrc_pktbuf_stats(void)
 {
-#ifdef MODULE_OD
     _unused_t *ptr = _first_unused;
     uint8_t *chunk = &_static_buf[0];
     int count = 0;
@@ -306,9 +305,6 @@ void gnrc_pktbuf_stats(void)
     if (chunk <= &_static_buf[CONFIG_GNRC_PKTBUF_SIZE - 1]) {
         _print_chunk(chunk, &_static_buf[CONFIG_GNRC_PKTBUF_SIZE] - chunk, count);
     }
-#else
-    DEBUG("pktbuf: needs od module\n");
-#endif
 }
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -240,12 +240,13 @@ gnrc_pktsnip_t gnrc_pktbuf_start_write(gnrc_pktsnip_t pkt)`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`#ifdef DEVELHELP`
`243`		`-#ifdef MODULE_OD`
`244`	`243`	`static inline void _print_chunk(void *chunk, size_t size, int num)`
`245`	`244`	`{`
`246`	`245`	`printf("=========== chunk %3i (%-10p size: %4" PRIuSIZE ") ===========\n", num, chunk,`
`247`	`246`	`size);`
	`247`	`+#ifdef MODULE_OD`
`248`	`248`	`od_hex_dump(chunk, size, OD_WIDTH_DEFAULT);`
	`249`	`+#endif`
`249`	`250`	`}`
`250`	`251`
`251`	`252`	`static inline void _print_ptr(_unused_t *ptr)`
`@@ -266,11 +267,9 @@ static inline void _print_unused(_unused_t *ptr)`
`266`	`267`	`_print_ptr(ptr->next);`
`267`	`268`	`printf(", size: %4u) ~\n", ptr->size);`
`268`	`269`	`}`
`269`		`-#endif`
`270`	`270`
`271`	`271`	`void gnrc_pktbuf_stats(void)`
`272`	`272`	`{`
`273`		`-#ifdef MODULE_OD`
`274`	`273`	`_unused_t *ptr = _first_unused;`
`275`	`274`	`uint8_t *chunk = &_static_buf[0];`
`276`	`275`	`int count = 0;`
`@@ -306,9 +305,6 @@ void gnrc_pktbuf_stats(void)`
`306`	`305`	`if (chunk <= &_static_buf[CONFIG_GNRC_PKTBUF_SIZE - 1]) {`
`307`	`306`	`_print_chunk(chunk, &_static_buf[CONFIG_GNRC_PKTBUF_SIZE] - chunk, count);`
`308`	`307`	`}`
`309`		`-#else`
`310`		`- DEBUG("pktbuf: needs od module\n");`
`311`		`-#endif`
`312`	`308`	`}`
`313`	`309`	`#endif`
`314`	`310`