emcute: never return from receive loop

nmeum · nmeum · commit 74e19d451cfa · 2019-10-07T15:12:20.000+02:00
Without this change an attacker would be able to stop the emcute server
by sending a crafted packet triggering this branch. The solution is
using `continue` instead of `return`.
diff --git a/sys/net/application_layer/emcute/emcute.c b/sys/net/application_layer/emcute/emcute.c
@@ -515,7 +515,7 @@ void emcute_run(uint16_t port, const char *id)
 
         if ((len < 0) && (len != -ETIMEDOUT)) {
             LOG_ERROR("[emcute] error while receiving UDP packet\n");
-            return;
+            continue;
         }
 
         if (len >= 2) {

Original file line number	Diff line number	Diff line change
`@@ -515,7 +515,7 @@ void emcute_run(uint16_t port, const char *id)`
`515`	`515`
`516`	`516`	`if ((len < 0) && (len != -ETIMEDOUT)) {`
`517`	`517`	`LOG_ERROR("[emcute] error while receiving UDP packet\n");`
`518`		`- return;`
	`518`	`+ continue;`
`519`	`519`	`}`
`520`	`520`
`521`	`521`	`if (len >= 2) {`