fix utils.py to not load contents as file paths#217
Merged
edmondchuc merged 5 commits intoRDFLib:masterfrom Apr 6, 2024
Merged
fix utils.py to not load contents as file paths#217edmondchuc merged 5 commits intoRDFLib:masterfrom
edmondchuc merged 5 commits intoRDFLib:masterfrom
Conversation
Collaborator
|
Thanks, I've refactored the code a bit and added a test. |
edmondchuc
approved these changes
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like PyLode is attempting to open a file with ontology however if this is a serialised graph the server can error trying to load this file
I have added a small simple detection logic however it may be simpler to pass the ontology variable to RDFLib and get it to do the path vs graph and the file type detection rather than rolling its own. Additionally i noticed a lack of strip() on the imput, this may cause errors with the data type detection not firing corretly