Skip to content

Update bitcoin 0.29 -> 0.30#116

Merged
RCasatta merged 3 commits intomasterfrom
update_bitcoin
Apr 4, 2023
Merged

Update bitcoin 0.29 -> 0.30#116
RCasatta merged 3 commits intomasterfrom
update_bitcoin

Conversation

@RCasatta
Copy link
Copy Markdown
Collaborator

draft because needs bitcoincore_rpc release

@apoelstra
Copy link
Copy Markdown
Member

This is blocking rust-miniscript, which is blocking elements-miniscript, which is blocking rust-simplicity.

If all these are stuck waiting for @stevenroose then we need another solution.

@apoelstra
Copy link
Copy Markdown
Member

I have spent some time switching from rust-bitcoincore-rpc to jsonrpc. It is quite annoying since I basically have to reimplement get_new_address, get_balance, get_block_count, etc., to get the unit tests to build.

I can keep going implementing all the "basic" functionality like this, but probably not things like get_blockchain_info which change from version to version, and which rust-bitcoincorerpc would traditionally smooth over. So downstream users would have a much less ergonomic library.

Should I continue in this vein or should we do something else?

@RCasatta RCasatta force-pushed the update_bitcoin branch 2 times, most recently from d0f3b9a to a0b9ad6 Compare April 4, 2023 15:12
@RCasatta RCasatta marked this pull request as ready for review April 4, 2023 18:54
@RCasatta
Copy link
Copy Markdown
Collaborator Author

RCasatta commented Apr 4, 2023

removed draft status, using a fork of bitcoincore-rpc with rust-bitcoin 0.30

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 387c7c6

Please hold off on release -- I have another PR I'd like to sneak in.

@apoelstra
Copy link
Copy Markdown
Member

#117

Also, should remove "draft" from this PR description.

@RCasatta RCasatta changed the title draft: update bitcoin 0.29 -> 0.30 Update bitcoin 0.29 -> 0.30 Apr 4, 2023
@RCasatta RCasatta merged commit e274ba0 into master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants