Skip to content

Conversation

@jakoss
Copy link
Contributor

@jakoss jakoss commented Aug 16, 2022

Since fragments can be embedded in other fragment managers than the supportFragmentManager of Activity - we can use our LocalView.current to look for a parent fragment

This should fix: #526

@jakoss jakoss requested a review from RBusarow as a code owner August 16, 2022 12:41
Copy link
Owner

@RBusarow RBusarow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@RBusarow RBusarow force-pushed the fix/compose-fragment-lookup branch from 4eedea1 to 98263c1 Compare August 23, 2022 20:05
@kodiakhq kodiakhq bot merged commit 4fdbb84 into RBusarow:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compose viewModel lookup ignores fragment in FragmentManager different than supportFragmentManager

2 participants