Skip to content

Commit e43cda5

Browse files
committed
Add GLES unit tests to Kokoro Windows CI
This required disabling the popup dialog which waits for a debugger to be attached. This is achieved by setting an environment variable: SWIFTSHADER_DISABLE_DEBUGGER_WAIT_DIALOG=1 Bug b/123360006 Change-Id: Ic1269fdae3088b08a85322cbc7e33a3bdd8292cb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27548 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Alexis Hétu <sugoi@google.com>
1 parent df5b28f commit e43cda5

File tree

3 files changed

+30
-5
lines changed

3 files changed

+30
-5
lines changed

src/OpenGL/libEGL/main.cpp

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,15 @@ extern "C" BOOL WINAPI DllMain(HINSTANCE instance, DWORD reason, LPVOID reserved
170170
{
171171
case DLL_PROCESS_ATTACH:
172172
#ifdef DEBUGGER_WAIT_DIALOG
173-
WaitForDebugger(instance);
173+
{
174+
char disable_debugger_wait_dialog[] = "0";
175+
GetEnvironmentVariable("SWIFTSHADER_DISABLE_DEBUGGER_WAIT_DIALOG", disable_debugger_wait_dialog, sizeof(disable_debugger_wait_dialog));
176+
177+
if(disable_debugger_wait_dialog[0] != '1')
178+
{
179+
WaitForDebugger(instance);
180+
}
181+
}
174182
#endif
175183
egl::attachProcess();
176184
break;

src/Vulkan/main.cpp

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,17 @@ extern "C" BOOL WINAPI DllMain(HINSTANCE instance, DWORD reason, LPVOID reserved
6262
switch(reason)
6363
{
6464
case DLL_PROCESS_ATTACH:
65-
#ifdef DEBUGGER_WAIT_DIALOG
66-
WaitForDebugger(instance);
67-
#endif
65+
#ifdef DEBUGGER_WAIT_DIALOG
66+
{
67+
char disable_debugger_wait_dialog[] = "0";
68+
GetEnvironmentVariable("SWIFTSHADER_DISABLE_DEBUGGER_WAIT_DIALOG", disable_debugger_wait_dialog, sizeof(disable_debugger_wait_dialog));
69+
70+
if(disable_debugger_wait_dialog[0] != '1')
71+
{
72+
WaitForDebugger(instance);
73+
}
74+
}
75+
#endif
6876
break;
6977
case DLL_THREAD_ATTACH:
7078
case DLL_THREAD_DETACH:

tests/kokoro/gcp_windows/continuous.bat

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,13 @@ cd git\SwiftShader
66

77
git submodule update --init
88

9-
"C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\MSBuild" SwiftShader.sln
9+
SET MSBUILD="C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\MSBuild"
10+
SET CONFIG=Debug
11+
12+
%MSBUILD% /p:Configuration=%CONFIG% SwiftShader.sln
13+
14+
SET PATH=%PATH%;T:\src\git\SwiftShader\out\Debug_x64
15+
SET SWIFTSHADER_DISABLE_DEBUGGER_WAIT_DIALOG=1
16+
17+
REM Run the GLES unit tests. TODO(capn): move to different directory (build?).
18+
bin\GLESUnitTests\x64\Debug\GLESUnitTests.exe

0 commit comments

Comments
 (0)