Skip to content

Russian translation update#68

Merged
RBN-Apps merged 10 commits into
RBN-Apps:mainfrom
RogeryRY:main
Feb 8, 2026
Merged

Russian translation update#68
RBN-Apps merged 10 commits into
RBN-Apps:mainfrom
RogeryRY:main

Conversation

@RogeryRY

Copy link
Copy Markdown
Contributor

Hi! I've translated all the strings into Russian.
Everything is up to date. Thanks for staying in open source

@RBN-Apps RBN-Apps left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RogeryRY
thanks for your PR! I have found two issues that need to be fixed before merging.

  1. Your folder is called values-ru which wont get recognized by the app, so please trim the whitespaces
  2. You have added some untranslatable strings in your translation (see review comments)

Since I don't understand Russian, I asked ChatGPT whether the translations are all correct in context. As someone who understands the language, you'll have to judge whether it would make sense to implement this:

  • dns_state_on_with_host: contains untranslated English word Hostname.
  • button_copy_grant_command: wording is understandable but unnatural in RU UI style.
  • recommended_for_you: phrasing is awkward/unidiomatic in Russian.
  • about_developer_info: mixed Russian/English (Open-source) style.

Comment thread app/src/main/res/ values-ru /strings.xml Outdated
Comment thread app/src/main/res/ values-ru /strings.xml Outdated
Comment thread app/src/main/res/ values-ru /strings.xml Outdated
Comment thread app/src/main/res/ values-ru /strings.xml Outdated
Remove untranslatable strings as requested
@RogeryRY RogeryRY requested a review from RBN-Apps February 7, 2026 19:16

@RBN-Apps RBN-Apps left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have still not fixed the problem with the whitespaces in the folder name values-ru and you removed in the previous commit some strings that are translatable and were already correctly translated. I wrote the details about it in the review comments, that are still unresolved.

@RogeryRY RogeryRY requested a review from RBN-Apps February 7, 2026 22:52
@RBN-Apps RBN-Apps merged commit 070c125 into RBN-Apps:main Feb 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants