Prevent installation of VanillaPlus#96
Merged
BigSpice merged 1 commit intoR2NorthstarTools:masterfrom Jul 20, 2024
Merged
Conversation
BigSpice
approved these changes
Jul 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to 0neGal/viper#241
essentially, VanillaPlus has a unique installation process and is intended to be used with existing client side mods for improved Vanilla compatibility.
a common miss-step by end-users is to install it through Mod Managers, this PR adds a check and prevents that.
I've through about multiple ways to do this, but I am not too confident in my use of Blend and I don't know if there is some kind of tool to maintain Localisations, so I just hardcoded it (Like its done in other places)
An alternative would be to remove the install button completely