feat: Manually find game if needed#7
Merged
GeckoEidechse merged 10 commits intoR2NorthstarTools:mainfrom Oct 19, 2022
Merged
Conversation
If game path was not found automatically and the user clicks the play button, FlightCore will ask him to point out his Titanfall2 installation folder.
Member
|
Ugh, still issues with private key not being able to be used if not pushed by me :c https://github.com/GeckoEidechse/FlightCore/actions/runs/3195020024/jobs/5215205469#step:6:716 |
Collaborator
Author
|
I suppose that's because the secret you created on your repo is not shared to forks (for security reasons) |
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
GeckoEidechse
approved these changes
Oct 19, 2022
Member
GeckoEidechse
left a comment
There was a problem hiding this comment.
Code looks fine and works as intended when testing on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4.
TODOs