Skip to content

feat: Thunderstore mods listing#54

Merged
GeckoEidechse merged 60 commits intoR2NorthstarTools:mainfrom
Alystrasz:feat/thunderstore-mods-listing
Nov 25, 2022
Merged

feat: Thunderstore mods listing#54
GeckoEidechse merged 60 commits intoR2NorthstarTools:mainfrom
Alystrasz:feat/thunderstore-mods-listing

Conversation

@Alystrasz
Copy link
Copy Markdown
Collaborator

@Alystrasz Alystrasz commented Nov 14, 2022

This introduces interface components for Thunderstore mods listing.

Capture d’écran de 2022-11-14 23-14-16

  • Displays information about mod
  • Thunderstore mod page can be opened in default browser via information button
  • Mods can be searched through (filtering by mod name / author / mod description)
TODOs
  • Responsive layout
  • Pagination (displaying all mods is slow on some devices) (THAT'S FOR ANOTHER TIME)
  • Search debounce (not to trigger search at each character input)
  • "Install/Installed" button text
  • Actual mod installation
  • Blur background on this view
  • Update view once a mod has been installed
  • Display "updating" instead of "installing"

Alystrasz and others added 27 commits November 11, 2022 18:49
In the future, we want the button text to change regarding status of the current
mod (installed, deprecated or not installed at all).
…/FlightCore into feat/thunderstore-mods-listing
@GeckoEidechse
Copy link
Copy Markdown
Member

GeckoEidechse commented Nov 14, 2022

Regarding:

  • Search throttle (not to trigger search at each character input)

I'd argue to keep it as is, as it feels really responsive to immediately update. ^^

  • Pagination (displaying all mods is slow on some devices)

Tbh devices where it's slow also probably won't be able to run Titanfall2 anyway, so I don't think pagination is necessary. In fact it will mess with the search and require updating it.

@GeckoEidechse GeckoEidechse force-pushed the feat/thunderstore-mods-listing branch from d063853 to 52e835d Compare November 21, 2022 21:56
@GeckoEidechse
Copy link
Copy Markdown
Member

In regards to

  • Blur background on this view

this is something that makes sense on other view as well. Maybe we should make this part of another PR that enables it for multiple views?

  • Display "updating" instead of "installing"

Is a minor issue tbh and shouldn't block this PR IMO ^^

@Alystrasz
Copy link
Copy Markdown
Collaborator Author

Lemme quote myself from 9 days ago:

Meh. I don't feel good shipping unfinished features 🥲

@GeckoEidechse
Copy link
Copy Markdown
Member

Ok for

  • Display "updating" instead of "installing"

I'm fine to agree. But for background blur, if we introduce it on Thunderstore view, we'd have to do it on every view, where we have content in front of background to stay consistent. In other words, everywhere except PlayView :P

Hence my suggestion to have this point a separate PR cause it just blows up this one out of proportions ^^

@Alystrasz
Copy link
Copy Markdown
Collaborator Author

Ok, so I still have ideas of new features for this:

  • putting outdated mods first in the list
  • allowing mods sorting by downloads count, stars count

But since you want to release v1.0.0 (and I don't want you to send me a pipe bomb), I propose to work on those later. 😄

@Alystrasz Alystrasz marked this pull request as ready for review November 24, 2022 22:09
@GeckoEidechse
Copy link
Copy Markdown
Member

  • putting outdated mods first in the list

I assume this in regard to making it easier to update mods? Cause we could just add the update check and update button to the ModsView as well ^^

In fact we might wanna redesign the ModsView soon anyway cause compared to ThunderstoreView it now looks kinda barren :P

@GeckoEidechse
Copy link
Copy Markdown
Member

GeckoEidechse commented Nov 24, 2022

With the blurred background, there's now a brighter edge around the edges of the application when in ThunderstoreView, is that intended? ^^

image

(Testing on Windows rn)

EDIT: Seems to be fine on Linux.

Copy link
Copy Markdown
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight, looks like it's mostly formatting related things and some clarifications about stuff I'm unsure about.

There's also the blurred white border issue (#54 (comment)), not sure how to fix that ^^

Given my lack of experience in frontend dev, my view tends to get fuzzy the moment I look at CSS so I'm just trusting you on that being right + testing looks good.

Let's hope I avoided bikeshedding as much as possible :P

Tested:

  • Installing mod
  • Updating mod
  • Card updates accordingly after installing/updating mod
  • Opening Thunderstore page of a mod

@Alystrasz
Copy link
Copy Markdown
Collaborator Author

With the blurred background, there's now a brighter edge around the edges of the application when in ThunderstoreView, is that intended?

Definitely not, it's another example of inconsistent rendering across different platforms.
I'll check how to prevent this on Windows.

Alystrasz and others added 3 commits November 25, 2022 06:45
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
@Alystrasz
Copy link
Copy Markdown
Collaborator Author

I'll check how to prevent this on Windows.

Can you try again?
I tried a fix with 286032d

@GeckoEidechse
Copy link
Copy Markdown
Member

I'll check how to prevent this on Windows.

Can you try again? I tried a fix with 286032d

Yup that seems to work :D

Copy link
Copy Markdown
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blur issue is now fixed on Windows. Overally LGTM both in testing and code ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants