feat: Thunderstore mods listing#54
Conversation
In the future, we want the button text to change regarding status of the current mod (installed, deprecated or not installed at all).
…/FlightCore into feat/thunderstore-mods-listing
|
Regarding:
I'd argue to keep it as is, as it feels really responsive to immediately update. ^^
Tbh devices where it's slow also probably won't be able to run Titanfall2 anyway, so I don't think pagination is necessary. In fact it will mess with the search and require updating it. |
d063853 to
52e835d
Compare
|
In regards to
this is something that makes sense on other view as well. Maybe we should make this part of another PR that enables it for multiple views?
Is a minor issue tbh and shouldn't block this PR IMO ^^ |
|
Lemme quote myself from 9 days ago:
|
|
Ok for
I'm fine to agree. But for background blur, if we introduce it on Thunderstore view, we'd have to do it on every view, where we have content in front of background to stay consistent. In other words, everywhere except PlayView :P Hence my suggestion to have this point a separate PR cause it just blows up this one out of proportions ^^ |
This way, after installing a mod, button text will display "Installed" instead of "Install".
|
Ok, so I still have ideas of new features for this:
But since you want to release v1.0.0 (and I don't want you to send me a pipe bomb), I propose to work on those later. 😄 |
I assume this in regard to making it easier to update mods? Cause we could just add the update check and update button to the ModsView as well ^^ In fact we might wanna redesign the ModsView soon anyway cause compared to ThunderstoreView it now looks kinda barren :P |
GeckoEidechse
left a comment
There was a problem hiding this comment.
Aight, looks like it's mostly formatting related things and some clarifications about stuff I'm unsure about.
There's also the blurred white border issue (#54 (comment)), not sure how to fix that ^^
Given my lack of experience in frontend dev, my view tends to get fuzzy the moment I look at CSS so I'm just trusting you on that being right + testing looks good.
Let's hope I avoided bikeshedding as much as possible :P
Tested:
- Installing mod
- Updating mod
- Card updates accordingly after installing/updating mod
- Opening Thunderstore page of a mod
Definitely not, it's another example of inconsistent rendering across different platforms. |
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Can you try again? |
Yup that seems to work :D |
GeckoEidechse
left a comment
There was a problem hiding this comment.
Blur issue is now fixed on Windows. Overally LGTM both in testing and code ^^

This introduces interface components for Thunderstore mods listing.
TODOs