feat: Add basic Proton management#383
feat: Add basic Proton management#383GeckoEidechse merged 18 commits intoR2NorthstarTools:mainfrom Jan200101:PR/proton
Conversation
|
I don't know how to fix the clippy issues because they are completely different locally. |
maybe try updating clippy? |
|
Thanks a lot for the PR <3 Will hopefully get to testing tomorrow, as for code review stuff, I think @catornot already mentioned most things ^^
This. CI pulls in newest Rust version which is currently |
my local clippy is clippy 0.1.70, this turned out to be some tauri thing that needed poking to make happy. |
Co-authored-by: GeckoEidechse <gecko.eidechse+git@pm.me>
GeckoEidechse
left a comment
There was a problem hiding this comment.
Some stuff I found from reading code and minor testing
this will make them execute independently of the main thread, keeping the UI active
this is done to give more feedback on what its doing
GeckoEidechse
left a comment
There was a problem hiding this comment.
Sorry I didn't review earlier. Took so long that by now it got some merge conflicts... x_x
|
Successful clippy checks without testing it prior 😎 (I totally am not forgetting to run it) |
Why aren't you using a lsp ( rust analyzer ); You wouldn't have to run anything. |
Not a fan of having to setup an lsp for everything I work for. |
(this is similar to how libthermite used to do it)
|
Test locally and it """works""". As mentioned on Discord, the libthermite api for proton stuff is very bare and dreadful to use (with an API break in a minor release that made this PR even more painful). But since this is a dev menu button, this is good to go as is. |
GeckoEidechse
left a comment
There was a problem hiding this comment.
Seems to work in testing in the sense that the install didn't panic and checking version afterwards printed a value.
Cannot really test if it is actually able to run Titanfall2 once the proton install is selected as I don't have a Linux install running Titanfall2. Well I guess it's still a dev feature after all so I'm fine with what it does so far.
Once the remaining comments + merge conflicts are addressed it should be good to merge :D
GeckoEidechse
left a comment
There was a problem hiding this comment.
Confirmed working in testing in the sense that installing, checking install, and removing works.
Also Steam seems to be able to pick it up
Didn't test actually running Northstar with it.
based on #180
adds logic for installing, uninstalling and getting the local NSProton version.