refactor: Parse using serde deserialisation#158
Merged
Conversation
Reduce code by making use of serde deserialisation. Still supports legacy method
While useful, it just made the code messy...
1 task
Alystrasz
approved these changes
Feb 6, 2023
Collaborator
Alystrasz
left a comment
There was a problem hiding this comment.
Good refactoring work!
LGTM, working on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of a bunch of code by making use of
serdefunctionality. This should have honestly been written like this in the first place but when I first usedserdeI wasn't aware of that functionality even though it's its defining feature ^^"