Skip to content

feat: Add button to force reinstall Northstar#154

Merged
Alystrasz merged 7 commits intomainfrom
feat/force-reinstall-northstar
Feb 25, 2023
Merged

feat: Add button to force reinstall Northstar#154
Alystrasz merged 7 commits intomainfrom
feat/force-reinstall-northstar

Conversation

@GeckoEidechse
Copy link
Copy Markdown
Member

Useful for reinstalling Northstar after installing a developer version.

Closes #153

Useful for reinstalling Northstar after installing a developer version.
@GeckoEidechse
Copy link
Copy Markdown
Member Author

Note that it doesn't update the version number displayed on the main / PlayView and I kinda don't know how to get it to update ^^"

Copy link
Copy Markdown
Collaborator

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works fine on Windows.

Could you add UI feedback to acknowledge FlightCore is currently reinstalling Northstar?
Currently, when you click the button, nothing happens on the interface.

@GeckoEidechse
Copy link
Copy Markdown
Member Author

Could you add UI feedback to acknowledge FlightCore is currently reinstalling Northstar?
Currently, when you click the button, nothing happens on the interface.

Any idea how I can implement that in a quick way in a few lines of code? ^^
Frontend is definitely not my forté and I rather not have the PR be blocked by me trying to figure out frontend stuff for a week :P

At the very least I could show a notification when it's done if that's enough.
(I usually just look at the console output cause I'm running from a local build :P)

@Alystrasz
Copy link
Copy Markdown
Collaborator

At the very least I could show a notification when it's done if that's enough.

Given that's a developer feature, a notification when starting downloading and a notification when it's done should do the trick :)

Sends a notification to indicate that reinstall process has started and
sends a second one once the process has finished/failed while also
clearing the old notification.
@GeckoEidechse
Copy link
Copy Markdown
Member Author

At the very least I could show a notification when it's done if that's enough.

Given that's a developer feature, a notification when starting downloading and a notification when it's done should do the trick :)

Done as suggested in af881ad ^^

Copy link
Copy Markdown
Collaborator

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Confirmed working on Windows.

@Alystrasz Alystrasz added this pull request to the merge queue Feb 25, 2023
Merged via the queue into main with commit 17c4f45 Feb 25, 2023
@Alystrasz Alystrasz deleted the feat/force-reinstall-northstar branch February 25, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option for force reinstall Northstar

2 participants