Skip to content

fix: App bar drag#13

Merged
GeckoEidechse merged 3 commits intoR2NorthstarTools:mainfrom
Alystrasz:fix/app-bar-drag
Oct 12, 2022
Merged

fix: App bar drag#13
GeckoEidechse merged 3 commits intoR2NorthstarTools:mainfrom
Alystrasz:fix/app-bar-drag

Conversation

@Alystrasz
Copy link
Copy Markdown
Collaborator

Closes #12.

The data-tauri-drag-region attribute cannot be put on menu bar directly because
it contains elements, so we emulate its behavior with a mousedown listener.
Copy link
Copy Markdown
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine apart from the comment I left ^^


<template>
<div id="fc_bg__container" data-tauri-drag-region />
<div id="fc_bg__container" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the title bar blur does not work on Linux it might make sense to keep the main area draggable for now ^^

Copy link
Copy Markdown
Collaborator Author

@Alystrasz Alystrasz Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the drag works on both Windows and Linux, I think title bar style is another issue :)
And I don't think we should enforce different UI behaviors regarding different platforms.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh fair enough

@GeckoEidechse GeckoEidechse merged commit 3ac693b into R2NorthstarTools:main Oct 12, 2022
@Alystrasz Alystrasz deleted the fix/app-bar-drag branch October 13, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FlightCore not draggable on top bar

2 participants