Skip to content

feat: Add self-updater logic in frontend#1096

Merged
GeckoEidechse merged 14 commits intomainfrom
feat/frontend-update-check
Aug 10, 2025
Merged

feat: Add self-updater logic in frontend#1096
GeckoEidechse merged 14 commits intomainfrom
feat/frontend-update-check

Conversation

@GeckoEidechse
Copy link
Copy Markdown
Member

Closes #1095

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Apr 27, 2025
@GeckoEidechse GeckoEidechse removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Apr 27, 2025
@GeckoEidechse
Copy link
Copy Markdown
Member Author

Okay, this is almost ready to go, I just need to figure out where to place the update checking logic in frontend. @Alystrasz any suggestions? ^^

@GeckoEidechse GeckoEidechse changed the title feat: Add initial logic for update check from frontend feat: Add self-updater logic in frontend Apr 27, 2025
@Alystrasz
Copy link
Copy Markdown
Collaborator

Okay, this is almost ready to go, I just need to figure out where to place the update checking logic in frontend. @Alystrasz any suggestions? ^^

Sorry for the late answer, thought I answered already!
I'd suggest placing it in the most top-level component, namely App.vue.

@Alystrasz
Copy link
Copy Markdown
Collaborator

Okay, this is almost ready to go, I just need to figure out where to place the update checking logic in frontend. @Alystrasz any suggestions? ^^

Sorry for the late answer, thought I answered already! I'd suggest placing it in the most top-level component, namely App.vue.

Actually, we can do even better, and put it in the store.ts module.
@GeckoEidechse there is already a _checkForFlightCoreUpdates method in there, should I replace it with your new update logic?

@Alystrasz
Copy link
Copy Markdown
Collaborator

Well, done in ed42fd2.
@GeckoEidechse how do you simulate a new flightcore version being available? (to test the popup)

@Alystrasz Alystrasz marked this pull request as ready for review May 23, 2025 11:37
@GeckoEidechse
Copy link
Copy Markdown
Member Author

@GeckoEidechse how do you simulate a new flightcore version being available? (to test the popup)

Uh, idk if Tauri does the check for != or > current version. Need to check the docs. I think you can set it to strict and then it should prompt for update on any version difference, though idk if you also need the signing key to be set for that

@Alystrasz
Copy link
Copy Markdown
Collaborator

Uh, idk if Tauri does the check for != or > current version. Need to check the docs. I think you can set it to strict and then it should prompt for update on any version difference, though idk if you also need the signing key to be set for that

I'm not sure we can do that, since the update checking magic is done by the updater plugin itself in the check method.
Also, looking at this official guide, I don't think we can test the update process without releasing builds...

@GeckoEidechse
Copy link
Copy Markdown
Member Author

Then we'll have to test in prod :>

@Alystrasz
Copy link
Copy Markdown
Collaborator

Then we'll have to test in prod :>

You'll probably have to setup the CI somehow then :)

Copy link
Copy Markdown
Member Author

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work in quick testing. At least it triggers the updating mechanism and launches the updater process. Whether it properly installs the update is something I cannot verify with debug build but assuming the mechanism is correctly implemented in Tauri upstream it should just work™ :)

@GeckoEidechse GeckoEidechse merged commit 73c9ff0 into main Aug 10, 2025
14 checks passed
@GeckoEidechse GeckoEidechse deleted the feat/frontend-update-check branch August 10, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add updater logic

2 participants