Conversation
🦋 Changeset detectedLatest commit: 91f299c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c6aab68 to
9200b9c
Compare
|
@wmertens ℹ️ Promptless reviewed this request and did not find a docs change to propose. |
27d233d to
339702f
Compare
maiieul
reviewed
Feb 25, 2026
Member
Author
|
@maiieul it's a perf change, moving the qrl creation as far up the scope as possible. That way, we create less objects and everything is faster |
6e605a4 to
1f43813
Compare
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
1f43813 to
db53b9e
Compare
commit: |
Varixo
reviewed
Mar 4, 2026
packages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__example_capture_imports.snap
Outdated
Show resolved
Hide resolved
packages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__example_default_export.snap
Outdated
Show resolved
Hide resolved
...ages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__example_derived_signals_cmp.snap
Outdated
Show resolved
Hide resolved
...ages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__example_derived_signals_div.snap
Outdated
Show resolved
Hide resolved
...optimizer/core/src/snapshots/qwik_core__test__example_derived_signals_multiple_children.snap
Outdated
Show resolved
Hide resolved
packages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__example_qwik_router_client.snap
Show resolved
Hide resolved
...zer/core/src/snapshots/qwik_core__test__should_split_spread_props_with_additional_prop5.snap
Outdated
Show resolved
Hide resolved
packages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__should_work.snap
Show resolved
Hide resolved
.../optimizer/core/src/snapshots/qwik_core__test__should_wrap_prop_from_destructured_array.snap
Outdated
Show resolved
Hide resolved
16ba102 to
fd1010e
Compare
wmertens
commented
Mar 4, 2026
Comment on lines
+37
to
+40
| import css1 from "./global.css"; | ||
| import css2 from "./style.css"; | ||
| // | ||
| export const App_component_useStyles_t35nSa5UV7U = `${css1}${css2}`; |
Member
Author
There was a problem hiding this comment.
BTW notice this, it was a bug, now it keeps the css.
Varixo
approved these changes
Mar 4, 2026
b5e4b52 to
c97d9b7
Compare
c97d9b7 to
31474a0
Compare
2 tasks
- self references: `const foo = $(() => console.log(foo))` works now - QRL hoisting: if a QRL doesn't capture anything, it's moved to module scope
902b4d7 to
d0197f1
Compare
1d6fcdf to
da1c8c5
Compare
this will cause many handlers to move to module scope, using less memory.
da1c8c5 to
91f299c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
q:psproperties whenever possible//to separate imports / qrls / code, for readability during debuggingThis should result in smaller dependency trees and faster loops