fix: unmount react root alongside with qwik#7864
Merged
gioboa merged 7 commits intoQwikDev:mainfrom Sep 2, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 76b0aa2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gioboa
reviewed
Aug 25, 2025
Member
gioboa
left a comment
There was a problem hiding this comment.
Thanks for your help @sashkashishka
Yep, it will be amazing to cover this part with tests
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Contributor
Author
|
@gioboa, sure, I'll make it |
gioboa
approved these changes
Sep 2, 2025
Member
gioboa
left a comment
There was a problem hiding this comment.
I tested the solution with the provided reproduction repo, and it's working fine.
Thanks so much for your help @sashkashishka 💪
Member
|
I would love some tests, but you can add them in a separate PR @sashkashishka. |
Contributor
Author
Merged
shairez
reviewed
Oct 1, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #7542
What is it?
Bug
Description
There is a bug, while navigating using SPA like approach, the qwikified react components don't call unmount callbacks specified in
useEffects hooks.There is an open issue that mentions such a problem #7542
In this PR the issue is fixed by calling unmount method in react root entity when the qwik wrapper unmounts.
I haven't added unit tests because I haven't found them. If they are needed, please let me know where to write them.
Checklist
pnpm change