Skip to content

fix: input's value is string when passing number#7182

Merged
shairez merged 17 commits intoQwikDev:build/v2from
JerryWu1234:v2v2v2
Jan 12, 2025
Merged

fix: input's value is string when passing number#7182
shairez merged 17 commits intoQwikDev:build/v2from
JerryWu1234:v2v2v2

Conversation

@JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Dec 20, 2024 •
edited by shairez
Loading

What is it?

  • Bug

Description

Repro

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 96c0105

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JerryWu1234 JerryWu1234 changed the base branch from main to build/v2 December 20, 2024 07:34
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 20, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7182

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7182

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7182

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7182

commit: ab81e32

Varixo
Varixo reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@Varixo Varixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR. Looks great, but we should add unit tests for it

@JerryWu1234
Copy link
Contributor Author

JerryWu1234 commented Dec 20, 2024

There are still other problems in another place.

@JerryWu1234 JerryWu1234 marked this pull request as ready for review December 31, 2024 05:48
@JerryWu1234 JerryWu1234 requested a review from a team as a code owner December 31, 2024 05:48
@JerryWu1234 JerryWu1234 requested a review from Varixo December 31, 2024 05:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 96c0105

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner January 11, 2025 07:20
@shairez
Copy link
Contributor

shairez commented Jan 12, 2025

Thanks @JerryWu1234 ! 🙏

@shairez shairez merged commit 42a6c35 into QwikDev:build/v2 Jan 12, 2025
14 checks passed
@github-actions github-actions bot mentioned this pull request Jan 12, 2025
Merged
@JerryWu1234 JerryWu1234 mentioned this pull request Jan 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Varixo Varixo Awaiting requested review from Varixo

Assignees

@JerryWu1234 JerryWu1234

Labels

next major

Projects

Qwik Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JerryWu1234 @shairez @Varixo