fix(installer): correct broken (404) 'for more info' URL in post-install message#4916
Merged
Conversation
Collaborator
|
Thanks for the PR! Template looks good ✓ On direction: this is a straightforward, well-scoped URL correction — the post-install "for more information" link currently points to the docs site but should point to the GitHub repo as the canonical project entry point. Clearly aligned with giving new users the right first impression. No CHANGELOG precedent needed for a cosmetic fix like this. On approach: the scope is minimal and correct — 3 files, 3 lines, exactly what's needed. The Moving on to code review. 🔍 中文说明感谢贡献！ 模板完整 ✓ 方向：这是一个简单明确的 URL 修正——安装成功后的"更多信息"链接目前指向文档站，应该指向 GitHub 仓库作为项目的权威入口。方向完全合理。这类美化修复不需要 CHANGELOG 先例。 方案：范围最小且正确——3 个文件、3 行改动，完全覆盖所需变更。 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
Collaborator
Code ReviewDiff is clean — exactly what I'd expect for this fix. Three files, one line each: TestingThis is a text-only URL change in installer scripts — tmux real-user-testing of the CLI doesn't apply here. Verification via the install-script test suite instead. Before (main branch)Old URL in installer output: After (this PR)New URL in installer output: All 97 tests pass on both before and after. The test assertion was updated to match the new URL — consistent and correct. 中文说明代码审查Diff 干净——完全符合预期。三个文件各改一行： 测试这是安装脚本中的纯文本 URL 修改，不适用于 CLI 的 tmux 真实用户测试。改用 install-script 测试套件验证。
测试断言已同步更新，一致且正确。 — Qwen Code · qwen3.7-max |
Collaborator
|
This is about as clean as a PR gets. A one-line URL fix across three files — installer shell script, batch script, and the matching test assertion — all consistent, all correct. My independent proposal matched the PR exactly: find the old URL in the installer scripts, update it, update the test. No surprises in the diff, nothing missed. The codebase grep confirmed no other instances of the bare Tests pass before and after. The motivation is sound — new users should land on the GitHub repo, not the docs site, as their first stop after installing. LGTM, ready to ship. ✅ 中文说明这是一个极其干净的 PR。三个文件各改一行 URL——shell 安装脚本、batch 安装脚本、测试断言——全部一致且正确。 我的独立方案与 PR 完全一致：找到安装脚本中的旧 URL，更新它，更新测试。Diff 无意外，无遗漏。全局搜索确认不存在其他裸 修改前后测试均通过。动机合理——新用户在安装后应该首先访问 GitHub 仓库而非文档站。 可以合并 ✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
approved these changes
Jun 10, 2026
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
qwen-code-ci-bot
approved these changes
Jun 10, 2026
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅ — qwen3.7-max via Qwen Code /review
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The post-install success message in both the shell installer (
install-qwen-standalone.sh) and the Windows batch installer (install-qwen-standalone.bat) prints a "For more information visit" URL. That URL pointed tohttps://qwenlm.github.io/qwen-code, which is not a valid address (404). This PR corrects it to the actual GitHub repository URLhttps://github.com/QwenLM/qwen-code.The corresponding assertion in
install-script.test.jsis updated to match.Why it's needed
The URL
https://qwenlm.github.io/qwen-codedoes not resolve — it returns a 404. New users who follow this link after installation hit a dead end. The correct address should be the GitHub repositoryhttps://github.com/QwenLM/qwen-code.Reviewer Test Plan
How to verify
bash scripts/installation/install-qwen-standalone.shin a dry-run or test environment)For more information visit https://github.com/QwenLM/qwen-code.batinstaller and confirm the same URL appearscd scripts/tests && node --test install-script.test.js— the smoke test should passEvidence (Before & After)
Before:
For more information visit https://qwenlm.github.io/qwen-code(404)After:
For more information visit https://github.com/QwenLM/qwen-codeTested on
Environment (optional)
N/A — text-only change in installer output.
Risk & Scope
.batinstaller was not executed locally; CI will cover it中文说明
本 PR 做了什么
Shell 安装脚本（
install-qwen-standalone.sh）和 Windows 批处理安装脚本（install-qwen-standalone.bat）在安装成功后会打印一行"For more information visit"的链接。该链接原来指向https://qwenlm.github.io/qwen-code，但这个地址无法访问（404），已修正为 GitHub 仓库地址https://github.com/QwenLM/qwen-code。install-script.test.js中对应的断言已同步更新。为什么需要这个改动
https://qwenlm.github.io/qwen-code这个地址不存在，用户点击后会遇到 404 页面。正确的地址应该是 GitHub 仓库https://github.com/QwenLM/qwen-code。验证方式
bash scripts/installation/install-qwen-standalone.sh或测试环境）For more information visit https://github.com/QwenLM/qwen-code.bat安装脚本，确认同一链接cd scripts/tests && node --test install-script.test.js，冒烟测试应通过风险与范围
.bat安装脚本未本地执行，由 CI 覆盖