fix(release): move constants above entry point to avoid TDZ error#4398
Merged
Conversation
MAX_UPLOAD_ATTEMPTS and INITIAL_BACKOFF_MS were declared after the isMainModule() guard that calls main(). In ES modules, const bindings are not initialized until the declaration is reached, so the runtime threw "Cannot access 'MAX_UPLOAD_ATTEMPTS' before initialization" during the Release workflow.
Contributor
📋 Review SummaryThis PR fixes a Temporal Dead Zone (TDZ) error in the release workflow by moving two 🔍 General Feedback
🎯 Specific FeedbackNo specific issues identified in this review. ✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a release-time runtime failure in scripts/upload-aliyun-oss-assets.js caused by ES module temporal dead zone (TDZ) behavior when main() is invoked before MAX_UPLOAD_ATTEMPTS / INITIAL_BACKOFF_MS are initialized.
Changes:
- Move
MAX_UPLOAD_ATTEMPTSandINITIAL_BACKOFF_MSabove theisMainModule(import.meta.url)entry point so they’re initialized beforemain()can calluploadWithRetry().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wenshao
previously approved these changes
May 22, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅ — DeepSeek/deepseek-v4-pro via Qwen Code /review
wenshao
reviewed
May 23, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No review findings. Downgraded from Approve to Comment: CI failing: Test (windows-latest, Node 22.x). — DeepSeek/deepseek-v4-pro via Qwen Code /review
The subprocess-based TDZ test relies on PATH resolution of bare 'ossutil' command which doesn't work on Windows without shell: true. Since the release workflow only runs on Ubuntu, remove the test to unblock CI.
pomelo-nwu
approved these changes
May 23, 2026
wenshao
approved these changes
May 23, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cannot access 'MAX_UPLOAD_ATTEMPTS' before initializationduring v0.16.0 publishconst MAX_UPLOAD_ATTEMPTSandconst INITIAL_BACKOFF_MSwere declared after theisMainModule()entry point that callsmain()→uploadAssets()→uploadWithRetry(), triggering a temporal dead zone (TDZ) error in ES modulesTest plan
node --check scripts/upload-aliyun-oss-assets.jspassesnode scripts/upload-aliyun-oss-assets.js --helpruns without error