chore(vscode): run development ACP CLI from source#4283
Merged
Conversation
Contributor
📋 Review SummaryThis PR enables VS Code extension development mode to run the ACP CLI from source ( 🔍 General Feedback
🎯 Specific Feedback🟢 Medium
🔵 Low
✅ Highlights
|
00d0efa to
7cafd12
Compare
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
wenshao
reviewed
May 18, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
[Suggestion] Missing test coverage: resolveQwenCliEntryPath has no test for the branch where extensionMode === Development but dev.js does not exist on disk. The existing tests cover the happy path (dev.js present) and non-development mode, but the fallback-to-bundled-CLI path is untested.
— DeepSeek/deepseek-v4-pro via Qwen Code /review
| } | ||
|
|
||
| return vscode.Uri.joinPath(extensionUri, 'dist', 'qwen-cli', 'cli.js').fsPath; | ||
| } |
Collaborator
There was a problem hiding this comment.
[Suggestion] resolveQwenCliEntryPath silently falls back to the bundled CLI when dev.js is not found even in ExtensionMode.Development. No log or warning is emitted — a developer would have no way to know their source changes aren't being picked up.
Suggested change
| } | |
| // If dev.js was not found, fall back to the bundled CLI. | |
| console.warn( | |
| '[WebViewProvider] dev.js not found at ' + | |
| path.resolve(extensionUri.fsPath, '..', '..', 'scripts', 'dev.js') + | |
| '; falling back to bundled CLI', | |
| ); | |
| return vscode.Uri.joinPath(extensionUri, 'dist', 'qwen-cli', 'cli.js').fsPath; |
— DeepSeek/deepseek-v4-pro via Qwen Code /review
wenshao
approved these changes
May 18, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅ — qwen-latest-series-invite-beta-v28 via Qwen Code /review
Collaborator
Local validation reportVerified head What I readTwo functional edits:
Build & static checks
The Unit tests
Logic-branch coverage (inline harness, 5 cases)Beyond the 2 tests shipped in the PR, I exercised every branch of
The branch matrix is complete and the safety property holds: production-mode behavior is byte-identical to before the PR, and dev-mode degrades gracefully to the bundled CLI if tmux smoke —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/dev.jsentrypoint, while packaged builds continue to use the bundled CLI.dist/qwen-cli/cli.js.Validation
node scripts/dev.js --versionreported the dev CLI version.packages/vscode-ide-companionwith F5, open the Qwen Code panel in the Extension Development Host, then confirm the ACP process uses the repositoryscripts/dev.jspath in the extension logs.devversion string from the source dev entrypoint.Scope / Risk
scripts/dev.js; if unavailable, the code falls back to the bundled CLI path.Testing Matrix
Testing matrix notes:
Linked Issues / Bugs
N/A