fix(cli): pass rewind selector test props#4211
Merged
Merged
Conversation
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Contributor
📋 Review SummaryThis PR fixes the 🔍 General Feedback
🎯 Specific FeedbackNo specific issues identified in this review.The PR correctly addresses the test setup issue. The implementation is sound:
✅ Highlights
|
wenshao
commented
May 16, 2026
wenshao
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review Summary
This PR fixes the RewindSelector test by adding missing required props (fileCheckpointingEnabled, fileHistoryService) after the component API changed. Clean mechanical fix — the 6-line change is correct, follows existing conventions, and tests pass locally.
Finding
Nice to have: The fileCheckpointingEnabled: true checkpointing path remains untested. The current test only exercises fileCheckpointingEnabled={false}. While this PR is focused on fixing test compilation, adding coverage for the checkpointing path (loading diff, showing restore options, handling restore) would be a valuable follow-up.
No Critical or Suggestion issues found. Security, correctness, code quality, and performance checks all passed.
— DeepSeek/deepseek-v4-pro via Qwen Code /review
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
doudouOUC
approved these changes
May 16, 2026
| import { FileHistoryService } from '@qwen-code/qwen-code-core'; | ||
| import type { HistoryItem } from '../types.js'; | ||
| import type { KeypressHandler, Key } from '../contexts/KeypressContext.js'; | ||
| import { useKeypress } from '../hooks/useKeypress.js'; |
Collaborator
There was a problem hiding this comment.
suggestion: Consider using a mock/stub instead of instantiating the real FileHistoryService. Since fileCheckpointingEnabled={false} means the component won't call any methods on this service, a simple cast is sufficient and avoids potential filesystem side-effects in unit tests:
Suggested change
| import { useKeypress } from '../hooks/useKeypress.js'; | |
| fileHistoryService = {} as FileHistoryService; |
This was referenced May 16, 2026
Collaborator
Review SummaryClean mechanical fix — no issues found beyond the inline suggestion already posted. Verified:
One suggestion (non-blocking): use Ship it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the RewindSelector test setup so it passes the required file checkpointing props after the component API changed.
Test plan