Skip to content

Check for is_terminal() directly after creating a new node#204

Merged
QueensGambit merged 1 commit intomasterfrom
fix_terminal_new_node
Aug 2, 2023
Merged

Check for is_terminal() directly after creating a new node#204
QueensGambit merged 1 commit intomasterfrom
fix_terminal_new_node

Conversation

@QueensGambit
Copy link
Owner

@QueensGambit QueensGambit commented Aug 2, 2023

This PR now checks for is_terminal() directly after creating a new node and sets the nodeBackup type accordingly.

./cutechess-cli -variant standard -openings file=chess.epd format=epd -pgnout fix_terminal_30ms.pgn -resign movecount=5 score=600 -draw movenumber=30 movecount=4 score=20 -concurrency 1 -engine name=ClassicAra-fixed-terminal cmd=./ClassicAra_fixed_terminal dir=/data/SL proto=uci -engine name=ClassicAra-master cmd=./ClassicAra_master dir=/data/SL proto=uci -each option.Fixed_Movetime=30 option.First_Device_ID=7 tc=40/6000+21 -games 2 -rounds 500 -repeat

Score of ClassicAra-fixed-terminal vs ClassicAra-master: 403 - 307 - 166  [0.555] 876
Elo difference: 38.2 +/- 20.8, LOS: 100.0 %, DrawRatio: 18.9 %
Finished match

@QueensGambit QueensGambit merged commit 282c671 into master Aug 2, 2023
@QueensGambit QueensGambit deleted the fix_terminal_new_node branch August 8, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@QueensGambit