Skip to content

Qt6: Add support for networkinformation plugins#791

Merged
EndrII merged 2 commits intoQuasarApp:mainfrom
rgriebl:patch-1
Feb 5, 2024
Merged

Qt6: Add support for networkinformation plugins#791
EndrII merged 2 commits intoQuasarApp:mainfrom
rgriebl:patch-1

Conversation

@rgriebl
Copy link
Contributor

@rgriebl rgriebl commented Jan 31, 2024

Qt 6.1 added https://doc.qt.io/qt-6/qnetworkinformation.html to the network module, but this needs plugins in networkinformation to be deployed.

@rgriebl
Qt6: Add support for networkinformation plugins
7242afc 
Qt 6.1 added https://doc.qt.io/qt-6/qnetworkinformation.html to the network module, but this needs plugins in `networkinformation` to be deployed.

Signed-off-by: rgriebl <robert@griebl.org>
@EndrII
Copy link
Member

EndrII commented Jan 31, 2024

Tanks you, but this fixes require changes in the tests cases
can you add into qt6.3 cases new plugins for window and Linux ?

Just see how it implemented for the TLS plugin of network.

@rgriebl
Adapt tests to the added networkinformation plugins
7769541 
Signed-off-by: rgriebl <robert@griebl.org>
@EndrII
Copy link
Member

EndrII commented Feb 1, 2024 •
edited
Loading

@rgriebl looks as the Qt 6.5 or higher contains libqglib in the networkinformation plugin module

Please add into qt6.5 module this library into qtLibs test cases. It should b help.

QCRITICAL: tstMain::qmlfiledialogtest() "added unnecessary file : /mnt/storage/Workers/ubuntu20/cmake/LinuxCMakeBuilderQt6/QuasarApp/CQtDeployer/Testing/CQtDeployer/DistributionKit/plugins/networkinformation/libqglib.so"
FAIL!  : tstMain::qmlfiledialogtest() 'false' returned FALSE. (runTestParams fail)
   Loc: [/mnt/storage/Workers/ubuntu20/cmake/LinuxCMakeBuilderQt6/QuasarApp/CQtDeployer/tests/units/testbase.cpp(130)]

@EndrII EndrII self-requested a review February 1, 2024 08:13
EndrII
EndrII requested changes Feb 5, 2024
View reviewed changes
Copy link
Member

@EndrII EndrII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add libqglib into linux-test (Qt 6.5)

@EndrII
Copy link
Member

EndrII commented Feb 5, 2024

okay, I will fix it itself ...

@EndrII EndrII merged commit eb3a750 into QuasarApp:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EndrII EndrII EndrII requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rgriebl @EndrII