Skip to content

disable native bridge & enable minting L2 native token on L1#49

Merged
blockchaindevsh merged 6 commits intoop-esfrom
disable_native_bridge
Jun 5, 2025
Merged

disable native bridge & enable minting L2 native token on L1#49
blockchaindevsh merged 6 commits intoop-esfrom
disable_native_bridge

Conversation

@blockchaindevsh
Copy link
Copy Markdown

@blockchaindevsh blockchaindevsh commented May 29, 2025

As a plan B for original CGT feature, we need to disable eth bridging on L1.

And we also need to enable minting L2 native token on L1 in order to migrating existing tokens on L1.

@qizhou
Copy link
Copy Markdown

qizhou commented May 30, 2025

It is possible to have a system config to disable and enable it (mainly to pass existing tests)?

Or a local variable to disable or enable by admin/owner.

@blockchaindevsh
Copy link
Copy Markdown
Author

It is possible to have a system config to disable and enable it (mainly to pass existing tests)?

Or a local variable to disable or enable by admin/owner.

Or we can keep this change on a separate branch, like mainnet_contracts_v1.8.0, and only use it for deployment? This way, the change is minimal.

@qizhou
Copy link
Copy Markdown

qizhou commented May 30, 2025

It is possible to have a system config to disable and enable it (mainly to pass existing tests)?
Or a local variable to disable or enable by admin/owner.

Or we can keep this change on a separate branch, like mainnet_contracts_v1.8.0, and only use it for deployment? This way, the change is minimal.

If the change is simple enough, I would like to put them into the same branch to avoid extra management overhead.

@blockchaindevsh
Copy link
Copy Markdown
Author

blockchaindevsh commented May 31, 2025

If the change is simple enough, I would like to put them into the same branch to avoid extra management overhead.

We'll maintain a branch for the mainnnet contracts(and op-deployer) any way, say we can't just use the contracts in op-es for mainnet.

@qizhou
Copy link
Copy Markdown

qizhou commented Jun 2, 2025

If the change is simple enough, I would like to put them into the same branch to avoid extra management overhead.

We'll maintain a branch for the mainnnet contracts(and op-deployer) any way, say we can't just use the contracts in op-es for mainnet.

A simple practice is that we maintain op-es and then cut a release after an official upstream release is announcement by

  • merging upstream
  • create a new release branch

@blockchaindevsh blockchaindevsh force-pushed the disable_native_bridge branch 2 times, most recently from 6a14e76 to 295ae7b Compare June 3, 2025 12:51
@blockchaindevsh blockchaindevsh force-pushed the disable_native_bridge branch from 295ae7b to c0afb23 Compare June 3, 2025 12:53
@blockchaindevsh
Copy link
Copy Markdown
Author

PTAL at the implementation c0afb23, the LOC is much more than expected -_-b

@blockchaindevsh
Copy link
Copy Markdown
Author

5bd002b should have addressed all above comments.

@blockchaindevsh blockchaindevsh force-pushed the disable_native_bridge branch from 32dfcf5 to 98080c1 Compare June 5, 2025 03:01
@blockchaindevsh blockchaindevsh merged commit 15b2d6e into op-es Jun 5, 2025
@blockchaindevsh blockchaindevsh changed the title disable native bridge disable native bridge & enable mint L2 native token on L1 Jun 5, 2025
@blockchaindevsh blockchaindevsh changed the title disable native bridge & enable mint L2 native token on L1 disable native bridge & enable minting L2 native token on L1 Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants