Skip to content

✨ NEW: Adding book and file pdf download#100

Merged
AakashGfude merged 14 commits intomasterfrom
pdf-download
May 5, 2021
Merged

✨ NEW: Adding book and file pdf download#100
AakashGfude merged 14 commits intomasterfrom
pdf-download

Conversation

@AakashGfude
Copy link
Copy Markdown
Member

@AakashGfude AakashGfude commented Apr 12, 2021

This PR adds a dropdown menu to the toolbar, for downloading single lecture pdf files (using print window), and book pdf file (which is created by pdflatex builder) .

The screenshot of which is attached below:
Screen Shot 2021-04-15 at 2 56 20 pm

The link for downloading book pdf at present is kept as book/python.pdf inside the build html folder.

@github-actions github-actions bot temporarily deployed to commit April 12, 2021 04:16 Inactive
@github-actions github-actions bot temporarily deployed to commit April 12, 2021 04:22 Inactive
@github-actions github-actions bot temporarily deployed to commit April 12, 2021 06:04 Inactive
@github-actions github-actions bot temporarily deployed to commit April 12, 2021 06:37 Inactive
@github-actions github-actions bot temporarily deployed to commit April 12, 2021 12:47 Inactive
@AakashGfude
Copy link
Copy Markdown
Member Author

The CI job in this PR is at present throwing error for the tornado version. It is downloading 6.0.4, but should requires >=6.1.0 .
The environment file is taken from lecture-python-programming.myst/environment.yml. The resolution for this would be to manually input the tornado dependency and version in that file.

@mmcky mmcky mentioned this pull request May 5, 2021
7 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented May 5, 2021

Codecov Report

Merging #100 (8ba3856) into master (cd13821) will increase coverage by 0.08%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   70.04%   70.12%   +0.08%     
==========================================
  Files           2        2              
  Lines         227      231       +4     
==========================================
+ Hits          159      162       +3     
- Misses         68       69       +1     
Flag Coverage Δ
pytests 70.12% <75.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quantecon_book_theme/__init__.py 58.90% <75.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd13821...8ba3856. Read the comment docs.

@github-actions github-actions bot temporarily deployed to commit May 5, 2021 04:52 Inactive
@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented May 5, 2021

@AakashGfude having a look at the test build above. The filename is attached with an html for the book pdf.

@AakashGfude
Copy link
Copy Markdown
Member Author

@AakashGfude having a look at the test build above. The filename is attached with an html for the book pdf.

ooh, yeah that's because it is not able to find the pdf in that location. will put the if clause here to show it only when the file is present.

@github-actions github-actions bot temporarily deployed to commit May 5, 2021 08:05 Inactive
@github-actions github-actions bot temporarily deployed to commit May 5, 2021 08:50 Inactive
@github-actions github-actions bot temporarily deployed to commit May 5, 2021 09:12 Inactive
@github-actions github-actions bot temporarily deployed to commit May 5, 2021 09:16 Inactive
@github-actions github-actions bot temporarily deployed to commit May 5, 2021 10:09 Inactive
@AakashGfude AakashGfude merged commit 222d5fe into master May 5, 2021
@mmcky mmcky deleted the pdf-download branch March 15, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants