Skip to content

Draft Lecture on Second Look at the Kalman filter#373

Merged
mmcky merged 19 commits intomainfrom
kalman-2
Oct 19, 2023
Merged

Draft Lecture on Second Look at the Kalman filter#373
mmcky merged 19 commits intomainfrom
kalman-2

Conversation

@HumphreyYang
Copy link
Copy Markdown
Member

@HumphreyYang HumphreyYang commented Oct 12, 2023

Hi @kp992,

Many thanks for the discussions in the email thread. I have created this draft PR to work on this lecture. We can invite Tom once we finalize the code part.

Best,
Humphrey

@HumphreyYang HumphreyYang marked this pull request as draft October 12, 2023 09:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 12, 2023

@HumphreyYang HumphreyYang marked this pull request as ready for review October 19, 2023 00:42
@mmcky mmcky added the ready label Oct 19, 2023
Copy link
Copy Markdown
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HumphreyYang this is looking good. There are just a few tidy up comments I have made to ensure compatibility with latex builds. etc

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Oct 19, 2023

@HumphreyYang I am not sure why the CI hasn't flagged an issue with the PDF build -- maybe error status has changed. I will look into this on the jupyter-book side but we will need to make some updates to get the pdf to build.

Do you have time to work on this and test locally?

@HumphreyYang
Copy link
Copy Markdown
Member Author

@HumphreyYang I am not sure why the CI hasn't flagged an issue with the PDF build -- maybe error status has changed. I will look into this on the jupyter-book side but we will need to make some updates to get the pdf to build.

Do you have time to work on this and test locally?

Hi @mmcky,

I am working on my research proposal this week. Would it be possible to merge this first once I tidy things up. I can work on the CI next week.

Many thanks in advance.

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Oct 19, 2023

@HumphreyYang I am not sure why the CI hasn't flagged an issue with the PDF build -- maybe error status has changed. I will look into this on the jupyter-book side but we will need to make some updates to get the pdf to build.
Do you have time to work on this and test locally?

Hi @mmcky,

I am working on my research proposal this week. Would it be possible to merge this first once I tidy things up. I can work on the CI next week.

Many thanks in advance.

thanks for letting me know you're busy @HumphreyYang that's helpful. I will see if I can fix these issues this afternoon. The live build won't deploy until pdf is fixed. :-) Good luck with the research proposal.

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Oct 19, 2023

OK pdf is compiling now. Will merge when CI passes

@HumphreyYang
Copy link
Copy Markdown
Member Author

OK pdf is compiling now. Will merge when CI passes

Great!! Many thanks for helping @mmcky!

@mmcky mmcky merged commit 5b05a79 into main Oct 19, 2023
@mmcky mmcky deleted the kalman-2 branch October 19, 2023 04:22
@kp992
Copy link
Copy Markdown
Contributor

kp992 commented Oct 20, 2023

This looks great. Thank you @mmcky, @HumphreyYang, and @thomassargent30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants