Skip to content

ENH: Add link checker GitHub Action#258

Merged
mmcky merged 5 commits intomainfrom
link-checker
Sep 13, 2022
Merged

ENH: Add link checker GitHub Action#258
mmcky merged 5 commits intomainfrom
link-checker

Conversation

@mmcky
Copy link
Copy Markdown
Contributor

@mmcky mmcky commented Sep 7, 2022

This PR runs a link checker on:

  1. schedule (daily),
  2. on the creation or reopening of a PR (so only will run once)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 7, 2022 •
edited
Loading

🚀 Deployed on https://631fd3860a7e9222b63a751c--nostalgic-wright-5fa355.netlify.app

@mmcky
Copy link
Copy Markdown
Contributor Author

mmcky commented Sep 7, 2022 •
edited
Loading

@HumphreyYang do you have time to do the same with this lecture set? Fixing broken for now is ok.

linkcheck-reports-2.zip

Note: this is now passing as link checker only runs when a PR is opened / reopened.

@mmcky
Copy link
Copy Markdown
Contributor Author

mmcky commented Sep 11, 2022

@HumphreyYang no rush but when you get a chance to push these can you ping me to review. Thanks.

@HumphreyYang
Copy link
Copy Markdown
Member

HumphreyYang commented Sep 11, 2022 •
edited
Loading

Hi @mmcky,

Thank you so much for your reminder. There are several issues with the following links:

For these two links, I could not find the _dowloads repository under the https://quantecon.org/lectures/.

linear_algebra.md:841: [broken] https://lectures.quantecon.org/_downloads/course_notes.pdf: 404 Client Error: Not Found for url: https://quantecon.org/lectures/_downloads/course_notes.pdf

mle.md:138: [broken] https://lectures.quantecon.org/_downloads/mle/fp.dta: 404 Client Error: Not Found for url: https://quantecon.org/lectures/_downloads/mle/fp.dta

These two links seem to be working. I think the false positive may be related to the request

ols.md:50: [broken] https://economics.mit.edu/files/4123: HTTPSConnectionPool(host='economics.mit.edu', port=443): Max retries exceeded with url: /files/4123 (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)')))

ols.md:89: [broken] https://economics.mit.edu/faculty/acemoglu/data/ajr2001: HTTPSConnectionPool(host='economics.mit.edu', port=443): Max retries exceeded with url: /faculty/acemoglu/data/ajr2001 (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)')))

Could you please help me to resolve these issues?

Many thanks in advance.

@mmcky
Copy link
Copy Markdown
Contributor Author

mmcky commented Sep 13, 2022

For these two links, I could not find the _dowloads repository under the https://quantecon.org/lectures/.

@HumphreyYang these files should be now located in _static/lecture_specific/{lecture-name}

https://github.com/QuantEcon/lecture-python.myst/tree/main/lectures/_static/lecture_specific/linear_models

@mmcky
Copy link
Copy Markdown
Contributor Author

mmcky commented Sep 13, 2022

@HumphreyYang looks like the https requests for these links aren't valid.

Perhaps we can revert these to http?

https://economics.mit.edu/ -> http://economics.mit.edu/

@HumphreyYang HumphreyYang reopened this Sep 13, 2022
@HumphreyYang HumphreyYang reopened this Sep 13, 2022
@HumphreyYang
Copy link
Copy Markdown
Member

HumphreyYang commented Sep 13, 2022

Hi @mmcky,

I think the linker checking has been passed on this repo. Please kindly review the changes and merge if it looks good to you.

Many thanks.

@mmcky
Copy link
Copy Markdown
Contributor Author

mmcky commented Sep 13, 2022

thanks @HumphreyYang

@mmcky mmcky merged commit f9ec4fd into main Sep 13, 2022
@mmcky mmcky deleted the link-checker branch September 13, 2022 00:58
@mmcky mmcky mentioned this pull request Nov 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmcky @HumphreyYang