Skip to content

Added Option Pricing Exercises#236

Merged
mmcky merged 11 commits intomainfrom
add_option_ex
Oct 3, 2022
Merged

Added Option Pricing Exercises#236
mmcky merged 11 commits intomainfrom
add_option_ex

Conversation

@jstac
Copy link
Copy Markdown
Contributor

@jstac jstac commented Oct 2, 2022

No description provided.

@jstac
Copy link
Copy Markdown
Contributor Author

jstac commented Oct 2, 2022

@HumphreyYang @mmcky , would one of you mind fixing the build errors and reviewing the PR?

@jstac jstac requested a review from mmcky October 2, 2022 19:43
@github-actions github-actions bot temporarily deployed to commit October 2, 2022 21:31 Inactive
@HumphreyYang
Copy link
Copy Markdown
Member

@HumphreyYang @mmcky , would one of you mind fixing the build errors and reviewing the PR?

I think it is just because the default values are not set. It should be fixed now.

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Oct 2, 2022

thanks @HumphreyYang

Copy link
Copy Markdown
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac just really minor style suggestion re: display math

@HumphreyYang
Copy link
Copy Markdown
Member

HumphreyYang commented Oct 3, 2022

Hi @jstac and @mmcky,

Another style-related update: I replaced the Hint: with hint admonitions.

@github-actions github-actions bot temporarily deployed to commit October 3, 2022 03:18 Inactive
@jstac
Copy link
Copy Markdown
Contributor Author

jstac commented Oct 3, 2022

Thanks guys. Nice catch @HumphreyYang .

@mmcky ,

  • should exercises end with {exercise-end} or just backticks?
  • please merge when ready.

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Oct 3, 2022

  • should exercises end with {exercise-end} or just backticks?

hey @jstac there are two types. If there are any embedded directives (i.e. code or math (using ticks)) then the exercise will need to start with exercise-start and then end with exercise-end. however if the gated syntax is not used then it can be a standard directive that starts with exercise and ends with the standard back ticks to close the directive.

@github-actions github-actions bot temporarily deployed to commit October 3, 2022 04:12 Inactive
@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Oct 3, 2022

@jstac are you OK with the commit suggestions listed above? They are all the same just adding a new line to mark the display math block

@jstac
Copy link
Copy Markdown
Contributor Author

jstac commented Oct 3, 2022

@jstac are you OK with the commit suggestions listed above? They are all the same just adding a new line to mark the display math block

For sure, please go ahead @mmcky

@mmcky mmcky self-requested a review October 3, 2022 04:30
@github-actions github-actions bot temporarily deployed to commit October 3, 2022 04:37 Inactive
@github-actions github-actions bot temporarily deployed to commit October 3, 2022 04:37 Inactive
@github-actions github-actions bot temporarily deployed to commit October 3, 2022 04:39 Inactive
@github-actions github-actions bot temporarily deployed to commit October 3, 2022 04:39 Inactive
@github-actions github-actions bot temporarily deployed to commit October 3, 2022 04:40 Inactive
@github-actions github-actions bot temporarily deployed to commit October 3, 2022 04:40 Inactive
@github-actions github-actions bot temporarily deployed to commit October 3, 2022 06:35 Inactive
@mmcky mmcky merged commit bdc2831 into main Oct 3, 2022
@mmcky mmcky deleted the add_option_ex branch October 3, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants