Conversation
|
@HumphreyYang I am adding a link checker to this repository and will roll it out to the other lecture sites one we fine tune the workflows. There are a couple of would you mind to look at those and fix them on this branch. Then I will reopen this PR and trigger another run of the link checker to see if it fails on |
|
Thanks @HumphreyYang this looks great. Link Checker is passing now. Thanks. |
|
Looking at the diff did you update the redirects as well? |
Hi @mmcky, I have tried the test again, it does not fail on |
I changed some of them, but not all as you can see from the test result. |
5c56373 to
e018ae1
Compare
Hi @mmcky, I have reverted changes that are not necessary. I think the link checker is not failing redirected links. Sorry for the misunderstanding before. |
|
thanks @HumphreyYang -- sorry I wasn't clear. We will want to update the redirects as well to reduce possible future failures. But I was interested to know if redirects cause CI to fail :-) It's good to know that it will only fail on broken links. |
This PR enables a link check run for the website based on GitHub Actions workflow
It will also run when a PR is opened.